You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Dinesh Chitlangia (JIRA)" <ji...@apache.org> on 2019/01/24 15:18:00 UTC

[jira] [Updated] (HDFS-14228) Incorrect getSnapshottableDirListing() javadoc

     [ https://issues.apache.org/jira/browse/HDFS-14228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dinesh Chitlangia updated HDFS-14228:
-------------------------------------
    Attachment: HDFS-14228.00.patch
        Status: Patch Available  (was: Open)

[~jojochuang] Thanks for reporting this. Attached patch 00 for review.

> Incorrect getSnapshottableDirListing() javadoc
> ----------------------------------------------
>
>                 Key: HDFS-14228
>                 URL: https://issues.apache.org/jira/browse/HDFS-14228
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 2.1.0-beta
>            Reporter: Wei-Chiu Chuang
>            Assignee: Dinesh Chitlangia
>            Priority: Major
>         Attachments: HDFS-14228.00.patch
>
>
> The Javadoc for {{DistributedFileSystem#getSnapshottableDirListing()}} is not consistent with {{FSNamesystem#getSnapshottableDirListing()}}
> {code:title=ClientProtocol#getSnapshottableDirListing()}
> /**
>    * Get listing of all the snapshottable directories.
>    *
>    * @return Information about all the current snapshottable directory
>    * @throws IOException If an I/O error occurred
>    */
>   @Idempotent
>   @ReadOnly(isCoordinated = true)
>   SnapshottableDirectoryStatus[] getSnapshottableDirListing()
>       throws IOException;
> {code}
> {code:title=DistributedFileSystem#getSnapshottableDirListing()}
> /**
>    * @return All the snapshottable directories
>    * @throws IOException
>    */
>   public SnapshottableDirectoryStatus[] getSnapshottableDirListing()
> {code}
> But the implementation at NameNode side is:
> {code:title=FSNamesystem#getSnapshottableDirListing()}
> /**
>    * Get the list of snapshottable directories that are owned 
>    * by the current user. Return all the snapshottable directories if the 
>    * current user is a super user.
>    * @return The list of all the current snapshottable directories
>    * @throws IOException
>    */
>   public SnapshottableDirectoryStatus[] getSnapshottableDirListing()
> {code}
> That is, if this method is called by a non-super user, it does not return all snapshottable directories. File this jira to get this corrected to avoid confusion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org