[Call-for-​​​Review] bug 119953 ([From Symphony]Undo redo insert file cause application crashed)

[Chen Peng <ch...@gmail.com>]

Hi all,
I have a fix for bug 119953.
https://issues.apache.org/ooo/show_bug.cgi?id=119953
It is about application crash when undo & redo a inserted file, because of
in the procedure of inserting file, a text node split and a text node join
action did not have corresponding undo recorded.

Anybody who could help to review it?
Thanks.

Re: [Call-for-​​​Review] bug 119953 ([From Symphony]Undo redo insert file cause application crashed)

[Oliver-Rainer Wittmann <or...@googlemail.com>]

Hi,

On 05.07.2012 10:44, Oliver-Rainer Wittmann wrote:
> Hi,
>
> On 26.06.2012 10:16, Chen Peng wrote:
>> Hi all,
>> I have a fix for bug 119953.
>> https://issues.apache.org/ooo/show_bug.cgi?id=119953
>> It is about application crash when undo & redo a inserted file, because of
>> in the procedure of inserting file, a text node split and a text node join
>> action did not have corresponding undo recorded.
>>
>> Anybody who could help to review it?
>> Thanks.
>>
>
> I am taking over this issue for reviewing the patch.
>

I have finished my review.
Please have a look at my comments in the issue - I have found an alternative 
solution which also has the benefit that it makes the "Insert - File" function 
more consistent.

Best regards, Oliver.

Re: [Call-for-​​​Review] bug 119953 ([From Symphony]Undo redo insert file cause application crashed)

[Oliver-Rainer Wittmann <or...@googlemail.com>]

Hi,

On 26.06.2012 10:16, Chen Peng wrote:
> Hi all,
> I have a fix for bug 119953.
> https://issues.apache.org/ooo/show_bug.cgi?id=119953
> It is about application crash when undo & redo a inserted file, because of
> in the procedure of inserting file, a text node split and a text node join
> action did not have corresponding undo recorded.
>
> Anybody who could help to review it?
> Thanks.
>

I am taking over this issue for reviewing the patch.

Best regards, Oliver.