You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/20 01:56:58 UTC
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request
#4376: comment subquery case down
tristaZero opened a new pull request #4376: comment subquery case down
URL: https://github.com/apache/incubator-shardingsphere/pull/4376
Fixes #4374.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4376:
comment subquery case down
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4376: comment subquery case down
URL: https://github.com/apache/incubator-shardingsphere/pull/4376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4376: comment subquery case down
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4376: comment subquery case down
URL: https://github.com/apache/incubator-shardingsphere/pull/4376#issuecomment-588578436
## Pull Request Test Coverage Report for [Build 9658](https://coveralls.io/builds/28843449)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **45** unchanged lines in **5** files lost coverage.
* Overall coverage decreased (**-0.2%**) to **57.006%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/ShardingConditions.java](https://coveralls.io/builds/28843449/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fcondition%2FShardingConditions.java#L43) | 1 | 57.14% |
| [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/generator/ConditionValueGeneratorFactory.java](https://coveralls.io/builds/28843449/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fcondition%2Fgenerator%2FConditionValueGeneratorFactory.java#L56) | 2 | 57.14% |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28843449/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
| [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/engine/WhereClauseShardingConditionEngine.java](https://coveralls.io/builds/28843449/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fcondition%2Fengine%2FWhereClauseShardingConditionEngine.java#L80) | 5 | 64.94% |
| [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouter.java](https://coveralls.io/builds/28843449/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouter.java#L85) | 34 | 36.07% |
<!-- | **Total:** | **45** | | -->
| Totals | [](https://coveralls.io/builds/28843449) |
| :-- | --: |
| Change from base [Build 886](https://coveralls.io/builds/28841393): | -0.2% |
| Covered Lines: | 11029 |
| Relevant Lines: | 19347 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4376:
comment subquery case down
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4376: comment subquery case down
URL: https://github.com/apache/incubator-shardingsphere/pull/4376#issuecomment-588578436
## Pull Request Test Coverage Report for [Build 1814](https://coveralls.io/builds/28843138)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **42** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.2%**) to **57.017%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/ShardingConditions.java](https://coveralls.io/builds/28843138/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fcondition%2FShardingConditions.java#L43) | 1 | 57.14% |
| [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/generator/ConditionValueGeneratorFactory.java](https://coveralls.io/builds/28843138/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fcondition%2Fgenerator%2FConditionValueGeneratorFactory.java#L56) | 2 | 57.14% |
| [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/engine/WhereClauseShardingConditionEngine.java](https://coveralls.io/builds/28843138/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fcondition%2Fengine%2FWhereClauseShardingConditionEngine.java#L80) | 5 | 64.94% |
| [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouter.java](https://coveralls.io/builds/28843138/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouter.java#L85) | 34 | 36.07% |
<!-- | **Total:** | **42** | | -->
| Totals | [](https://coveralls.io/builds/28843138) |
| :-- | --: |
| Change from base [Build 886](https://coveralls.io/builds/28841393): | -0.2% |
| Covered Lines: | 11031 |
| Relevant Lines: | 19347 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4376:
comment subquery case down
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4376: comment subquery case down
URL: https://github.com/apache/incubator-shardingsphere/pull/4376#issuecomment-588585942
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4376?src=pr&el=h1) Report
> Merging [#4376](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4376?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/d52fb9ce6acace08f00a609be31e5587441c87f7?src=pr&el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4376?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4376 +/- ##
============================================
- Coverage 53.77% 53.55% -0.22%
Complexity 351 351
============================================
Files 1048 1048
Lines 19347 19347
Branches 3562 3562
============================================
- Hits 10403 10362 -41
- Misses 8286 8329 +43
+ Partials 658 656 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4376?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ngsphere/sharding/route/engine/ShardingRouter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4376/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJvdXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS9lbmdpbmUvU2hhcmRpbmdSb3V0ZXIuamF2YQ==) | `27.86% <0%> (-49.19%)` | `0% <0%> (ø)` | |
| [...ing/route/engine/condition/ShardingConditions.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4376/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJvdXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS9lbmdpbmUvY29uZGl0aW9uL1NoYXJkaW5nQ29uZGl0aW9ucy5qYXZh) | `14.28% <0%> (-28.58%)` | `0% <0%> (ø)` | |
| [...tion/generator/ConditionValueGeneratorFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4376/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJvdXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS9lbmdpbmUvY29uZGl0aW9uL2dlbmVyYXRvci9Db25kaXRpb25WYWx1ZUdlbmVyYXRvckZhY3RvcnkuamF2YQ==) | `42.85% <0%> (-28.58%)` | `0% <0%> (ø)` | |
| [...ion/engine/WhereClauseShardingConditionEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4376/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJvdXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS9lbmdpbmUvY29uZGl0aW9uL2VuZ2luZS9XaGVyZUNsYXVzZVNoYXJkaW5nQ29uZGl0aW9uRW5naW5lLmphdmE=) | `50.64% <0%> (-9.1%)` | `0% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4376?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4376?src=pr&el=footer). Last update [d52fb9c...1855d52](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4376?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services