You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2020/07/08 08:59:16 UTC
Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Greg Mann.
Bugs: MESOS-10148
https://issues.apache.org/jira/browse/MESOS-10148
Repository: mesos
Description
-------
Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
Diffs
-----
include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72661/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221153
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72660, 72661]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On July 8, 2020, 8:59 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
>
> (Updated July 8, 2020, 8:59 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10148
> https://issues.apache.org/jira/browse/MESOS-10148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
>
>
> Diff: https://reviews.apache.org/r/72661/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221169
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72660, 72661]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On July 8, 2020, 8:59 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
>
> (Updated July 8, 2020, 8:59 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10148
> https://issues.apache.org/jira/browse/MESOS-10148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
>
>
> Diff: https://reviews.apache.org/r/72661/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221197
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72660, 72661]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On July 13, 2020, 2:51 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
>
> (Updated July 13, 2020, 2:51 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10148
> https://issues.apache.org/jira/browse/MESOS-10148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
>
>
> Diff: https://reviews.apache.org/r/72661/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221319
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On July 22, 2020, 6:26 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
>
> (Updated July 22, 2020, 6:26 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10148
> https://issues.apache.org/jira/browse/MESOS-10148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
>
>
> Diff: https://reviews.apache.org/r/72661/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/
-----------------------------------------------------------
(Updated July 22, 2020, 2:26 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Addressed review comments.
Bugs: MESOS-10148
https://issues.apache.org/jira/browse/MESOS-10148
Repository: mesos
Description
-------
Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
Diffs (updated)
-----
include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72661/diff/6/
Changes: https://reviews.apache.org/r/72661/diff/5-6/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Qian Zhang <zh...@gmail.com>.
> On July 17, 2020, 7:22 a.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Line 1106 (original), 1106 (patched)
> > <https://reviews.apache.org/r/72661/diff/5/?file=2235882#file2235882line1106>
> >
> > I'm not sure that we should mark this as deprecated, since it's still useful for the LVM driver?
>
> Qian Zhang wrote:
> Yeah, it is still userful for the LVM driver, but will we continue to support it in long term?
>
> Greg Mann wrote:
> I would propose that we don't tie this patch to the decision of whether or not we want to continue supporting it, I'm not sure what the answer for that is?
Agree, let me remove `deprecated=true`.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221241
-----------------------------------------------------------
On July 22, 2020, 2:26 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
>
> (Updated July 22, 2020, 2:26 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10148
> https://issues.apache.org/jira/browse/MESOS-10148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
>
>
> Diff: https://reviews.apache.org/r/72661/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Greg Mann <gr...@mesosphere.io>.
> On July 16, 2020, 11:22 p.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Line 1106 (original), 1106 (patched)
> > <https://reviews.apache.org/r/72661/diff/5/?file=2235882#file2235882line1106>
> >
> > I'm not sure that we should mark this as deprecated, since it's still useful for the LVM driver?
>
> Qian Zhang wrote:
> Yeah, it is still userful for the LVM driver, but will we continue to support it in long term?
I would propose that we don't tie this patch to the decision of whether or not we want to continue supporting it, I'm not sure what the answer for that is?
> On July 16, 2020, 11:22 p.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Lines 1126-1129 (patched)
> > <https://reviews.apache.org/r/72661/diff/5/?file=2235882#file2235882line1126>
> >
> > Should we define this next to `CSIPluginContainerInfo` for consistency? Also, can we move the `Service` message up to the top level of the namespace without breaking the API? Would be nice for `Service` to sit higher now that it's used by two messages; but the name might be too generic for the top level...
>
> Qian Zhang wrote:
> > Should we define this next to CSIPluginContainerInfo for consistency?
>
> Yes, I agree.
>
> > Also, can we move the Service message up to the top level of the namespace without breaking the API? Would be nice for Service to sit higher now that it's used by two messages; but the name might be too generic for the top level...
>
> Did you mean the `Service` enum definition? Actually I thought it before and I agree we may have to rename it to something CSI specific, like `CSIPluginService`. I really want to do this refactor, but I guess that may break backward compatibility since DSS is currrently using it.
Yea I guess we need to leave the current enum where it is. So we could either add a second enum at the top level or use the existing one? I think I'm fine with either way, neither of them is ideal.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221241
-----------------------------------------------------------
On July 16, 2020, 1:47 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
>
> (Updated July 16, 2020, 1:47 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10148
> https://issues.apache.org/jira/browse/MESOS-10148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
>
>
> Diff: https://reviews.apache.org/r/72661/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Qian Zhang <zh...@gmail.com>.
> On July 17, 2020, 7:22 a.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Line 1106 (original), 1106 (patched)
> > <https://reviews.apache.org/r/72661/diff/5/?file=2235882#file2235882line1106>
> >
> > I'm not sure that we should mark this as deprecated, since it's still useful for the LVM driver?
Yeah, it is still userful for the LVM driver, but will we continue to support it in long term?
> On July 17, 2020, 7:22 a.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Lines 1126-1129 (patched)
> > <https://reviews.apache.org/r/72661/diff/5/?file=2235882#file2235882line1126>
> >
> > Should we define this next to `CSIPluginContainerInfo` for consistency? Also, can we move the `Service` message up to the top level of the namespace without breaking the API? Would be nice for `Service` to sit higher now that it's used by two messages; but the name might be too generic for the top level...
> Should we define this next to CSIPluginContainerInfo for consistency?
Yes, I agree.
> Also, can we move the Service message up to the top level of the namespace without breaking the API? Would be nice for Service to sit higher now that it's used by two messages; but the name might be too generic for the top level...
Did you mean the `Service` enum definition? Actually I thought it before and I agree we may have to rename it to something CSI specific, like `CSIPluginService`. I really want to do this refactor, but I guess that may break backward compatibility since DSS is currrently using it.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221241
-----------------------------------------------------------
On July 16, 2020, 9:47 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
>
> (Updated July 16, 2020, 9:47 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10148
> https://issues.apache.org/jira/browse/MESOS-10148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
>
>
> Diff: https://reviews.apache.org/r/72661/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221241
-----------------------------------------------------------
include/mesos/mesos.proto
Line 1106 (original), 1106 (patched)
<https://reviews.apache.org/r/72661/#comment310088>
I'm not sure that we should mark this as deprecated, since it's still useful for the LVM driver?
include/mesos/mesos.proto
Lines 1126-1129 (patched)
<https://reviews.apache.org/r/72661/#comment310090>
Should we define this next to `CSIPluginContainerInfo` for consistency? Also, can we move the `Service` message up to the top level of the namespace without breaking the API? Would be nice for `Service` to sit higher now that it's used by two messages; but the name might be too generic for the top level...
- Greg Mann
On July 16, 2020, 1:47 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
>
> (Updated July 16, 2020, 1:47 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10148
> https://issues.apache.org/jira/browse/MESOS-10148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
>
>
> Diff: https://reviews.apache.org/r/72661/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/
-----------------------------------------------------------
(Updated July 16, 2020, 9:47 a.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Added default volume for the `name` field.
Bugs: MESOS-10148
https://issues.apache.org/jira/browse/MESOS-10148
Repository: mesos
Description
-------
Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
Diffs (updated)
-----
include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72661/diff/5/
Changes: https://reviews.apache.org/r/72661/diff/4-5/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/
-----------------------------------------------------------
(Updated July 15, 2020, 4:17 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Introduced a repeated field for CSI service endpoints.
Bugs: MESOS-10148
https://issues.apache.org/jira/browse/MESOS-10148
Repository: mesos
Description
-------
Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
Diffs (updated)
-----
include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72661/diff/4/
Changes: https://reviews.apache.org/r/72661/diff/3-4/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/
-----------------------------------------------------------
(Updated July 13, 2020, 10:51 a.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Renamed `endpoint` field to `node_service_endpoint`.
Bugs: MESOS-10148
https://issues.apache.org/jira/browse/MESOS-10148
Repository: mesos
Description
-------
Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
Diffs (updated)
-----
include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72661/diff/3/
Changes: https://reviews.apache.org/r/72661/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221176
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72660, 72661]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On July 10, 2020, 2:31 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
>
> (Updated July 10, 2020, 2:31 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10148
> https://issues.apache.org/jira/browse/MESOS-10148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
>
>
> Diff: https://reviews.apache.org/r/72661/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/
-----------------------------------------------------------
(Updated July 10, 2020, 10:31 a.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Addressed review comments.
Bugs: MESOS-10148
https://issues.apache.org/jira/browse/MESOS-10148
Repository: mesos
Description
-------
Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
Diffs (updated)
-----
include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72661/diff/2/
Changes: https://reviews.apache.org/r/72661/diff/1-2/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Qian Zhang <zh...@gmail.com>.
> On July 10, 2020, 8:26 a.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Lines 1108-1112 (original), 1108-1116 (patched)
> > <https://reviews.apache.org/r/72661/diff/1/?file=2235533#file2235533line1108>
> >
> > Is it true that only one of these must be set? Should we note that?
Yes! I have added a comment to note that.
> On July 10, 2020, 8:26 a.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Lines 1118-1120 (patched)
> > <https://reviews.apache.org/r/72661/diff/1/?file=2235533#file2235533line1118>
> >
> > Perhaps:
> >
> > "The root directory of all the target paths managed by the CSI plugin. Each volume will be published by the CSI plugin at a sub-directory under this path."
Agree!
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221172
-----------------------------------------------------------
On July 8, 2020, 4:59 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
>
> (Updated July 8, 2020, 4:59 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10148
> https://issues.apache.org/jira/browse/MESOS-10148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
>
>
> Diff: https://reviews.apache.org/r/72661/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd
party CSI plugins.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221172
-----------------------------------------------------------
include/mesos/mesos.proto
Lines 1108-1112 (original), 1108-1116 (patched)
<https://reviews.apache.org/r/72661/#comment309958>
Is it true that only one of these must be set? Should we note that?
include/mesos/mesos.proto
Lines 1118-1120 (patched)
<https://reviews.apache.org/r/72661/#comment309957>
Perhaps:
"The root directory of all the target paths managed by the CSI plugin. Each volume will be published by the CSI plugin at a sub-directory under this path."
- Greg Mann
On July 8, 2020, 8:59 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
>
> (Updated July 8, 2020, 8:59 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10148
> https://issues.apache.org/jira/browse/MESOS-10148
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
>
>
> Diff: https://reviews.apache.org/r/72661/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>