[GitHub] [nifi] zenfenan commented on a change in pull request #4290: NIFI-6701: Fix Future execution handling

[GitBox <gi...@apache.org>]

zenfenan commented on a change in pull request #4290:
URL: https://github.com/apache/nifi/pull/4290#discussion_r431341413



##########
File path: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSub.java
##########
@@ -162,7 +162,7 @@ public void onTrigger(ProcessContext context, ProcessSession session) throws Pro
 
                     ApiFuture<String> messageIdFuture = publisher.publish(message);
 
-                    while (messageIdFuture.isDone()) {
+                    while (!messageIdFuture.isDone()) {

Review comment:
       @markap14 That is true. I understand that `.get()` is a blocking call but when I was implementing this processor and tested this without this waiting while loop, I saw a few messages weren't getting published. I wasn't sure if it is something on the GCP side. I am not sure if it is still an issue and we can drop that piece of code since I don't have available GCP resources to try. Maybe @pvillard31 will have some idea.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org