You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/06/29 22:44:18 UTC
[GitHub] [superset] justinpark opened a new pull request, #24559: chore(native filters): Expandable filter config modal
justinpark opened a new pull request, #24559:
URL: https://github.com/apache/superset/pull/24559
### SUMMARY
The native filters modal width is unnecessarily narrow which results in a suboptimal UX—excessive scrolling—especially when either the filter names and/or datasets/column names are long.
This commit adds an option to make the 'Add and edit filters' modal wider
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
https://github.com/apache/superset/assets/1392866/6027a46b-aa5f-4f1d-8656-52d7c33c9928
Before:
https://github.com/apache/superset/assets/1392866/7d6311ac-2fa8-4b9b-8656-1e0dd9b67f43
### TESTING INSTRUCTIONS
Go to dashboard and choose a dataset contains a long name column name
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #24559: chore(native filters): Expandable filter config modal
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #24559:
URL: https://github.com/apache/superset/pull/24559#issuecomment-1613897616
> in addition to the scroll bars, is there merit in making the default modal size wider?
Sure. I can adjust the default width from 50% to 70%
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #24559: chore(native filters): Expandable filter config modal
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24559:
URL: https://github.com/apache/superset/pull/24559#issuecomment-1613892473
@justinpark in addition to the scroll bars, is there merit in making the default modal size wider?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #24559: chore(native filters): Expandable filter config modal
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #24559:
URL: https://github.com/apache/superset/pull/24559#discussion_r1253537912
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx:
##########
@@ -580,8 +601,26 @@ function FiltersConfigModal({
<StyledModalWrapper
visible={isOpen}
maskClosable={false}
- title={t('Add and edit filters')}
- width="50%"
+ title={
+ <div
+ css={css`
+ display: flex;
+ justify-content: space-between;
+ align-items: flex-end;
+ margin-right: 50px;
+ `}
+ >
+ <div>{t('Add and edit filters')}</div>
+ <ToggleIcon
+ iconSize="l"
+ iconColor={theme.colors.grayscale.base}
+ onClick={toggleExpand}
+ />
+ </div>
+ }
+ width="70%"
+ {...(expanded && { width: '100%', height: '100%' })}
Review Comment:
Given that `StyleModalWrapper` is already receiving the `expanded` property, could you deal with `width` and `height` there and remove these two lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark merged pull request #24559: chore(native filters): Expandable filter config modal
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #24559:
URL: https://github.com/apache/superset/pull/24559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #24559: chore(native filters): Expandable filter config modal
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #24559:
URL: https://github.com/apache/superset/pull/24559#issuecomment-1633182084
> Thanks for the change justinpark! I am worried that because the icons are so similar and close to each other, people might confuse them. I think in other places we use this icon (below) and using this one would probably help. Would it be ok to swap? <img alt="image" width="430" src="https://user-images.githubusercontent.com/36897697/252910739-e5957cdd-d33f-44a0-b4dd-e878ee93824e.png">
>
> I think in general we have to bump the width of the modal in the default mode to ~880px (and resize just after it not longer fits in the screen), so that everything is more visible. Do you think you could include it in the PR or should it be included in a new one?
Sounds good. I updated the location of the button to the next of the footer buttons.
<img width="283" alt="Screenshot 2023-07-12 at 1 33 09 PM" src="https://github.com/apache/superset/assets/1392866/5101ce99-097a-430a-af02-a12068d67848">
I also updated the default width to 880px as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24559: chore(native filters): Expandable filter config modal
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24559:
URL: https://github.com/apache/superset/pull/24559#issuecomment-1622260947
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24559](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (93f0c2f) into [master](https://app.codecov.io/gh/apache/superset/commit/38df1a873f3bbfcdc5a7af6aaf7b17f8c7a9e08c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (38df1a8) will **increase** coverage by `0.00%`.
> The diff coverage is `64.53%`.
> :exclamation: Current head 93f0c2f differs from pull request most recent head c18248e. Consider uploading reports for the commit c18248e to get more accurate results
```diff
@@ Coverage Diff @@
## master #24559 +/- ##
=======================================
Coverage 69.08% 69.08%
=======================================
Files 1906 1906
Lines 74114 74190 +76
Branches 8155 8168 +13
=======================================
+ Hits 51200 51254 +54
- Misses 20795 20809 +14
- Partials 2119 2127 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.78% <48.05%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/components/labelUtils.tsx](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvbGFiZWxVdGlscy50c3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `48.25% <ø> (ø)` | |
| [superset-frontend/src/components/Tooltip/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcC9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...ilters/FiltersConfigModal/FilterTitleContainer.tsx](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlQ29udGFpbmVyLnRzeA==) | `79.41% <ø> (ø)` | |
| [...ses/DatabaseModal/DatabaseConnectionForm/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL0RhdGFiYXNlQ29ubmVjdGlvbkZvcm0vaW5kZXgudHN4) | `81.81% <ø> (ø)` | |
| [superset-frontend/src/pages/ChartList/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0NoYXJ0TGlzdC9pbmRleC50c3g=) | `55.79% <ø> (+0.40%)` | :arrow_up: |
| [superset/reports/api.py](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvcmVwb3J0cy9hcGkucHk=) | `90.29% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/hooks.ts](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `52.38% <11.11%> (-0.76%)` | :arrow_down: |
| [...end/src/features/databases/DatabaseModal/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `43.55% <42.85%> (-0.09%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `62.80% <50.00%> (-1.02%)` | :arrow_down: |
| ... and [20 more](https://app.codecov.io/gh/apache/superset/pull/24559?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24559/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #24559: chore(native filters): Expandable filter config modal
Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.
kasiazjc commented on PR #24559:
URL: https://github.com/apache/superset/pull/24559#issuecomment-1632099115
Thanks for the change @justinpark! I am worried that because the icons are so similar and close to each other, people might confuse them. I think in other places we use this icon (below) and using this one would probably help. Would it be ok to swap?
<img width="430" alt="image" src="https://github.com/apache/superset/assets/36897697/e5957cdd-d33f-44a0-b4dd-e878ee93824e">
I think in general we have to bump the width of the modal in the default mode to ~880px (and resize just after it not longer fits in the screen), so that everything is more visible. Do you think you could include it in the PR or should it be included in a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #24559: chore(native filters): Expandable filter config modal
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #24559:
URL: https://github.com/apache/superset/pull/24559#issuecomment-1631153879
@michael-s-molina could you review the update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #24559: chore(native filters): Expandable filter config modal
Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.
kasiazjc commented on PR #24559:
URL: https://github.com/apache/superset/pull/24559#issuecomment-1641952000
> > Thanks for the change justinpark! I am worried that because the icons are so similar and close to each other, people might confuse them. I think in other places we use this icon (below) and using this one would probably help. Would it be ok to swap? <img alt="image" width="430" src="https://user-images.githubusercontent.com/36897697/252910739-e5957cdd-d33f-44a0-b4dd-e878ee93824e.png">
> > I think in general we have to bump the width of the modal in the default mode to ~880px (and resize just after it not longer fits in the screen), so that everything is more visible. Do you think you could include it in the PR or should it be included in a new one?
>
> Sounds good. I updated the location of the button to the next of the footer buttons. <img alt="Screenshot 2023-07-12 at 1 33 09 PM" width="283" src="https://user-images.githubusercontent.com/1392866/253094673-5101ce99-097a-430a-af02-a12068d67848.png">
>
> I also updated the default width to 880px as well.
Amazing, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org