You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2019/05/30 06:34:52 UTC
[kudu-CR] [java] Deflake TestSecurity.testImportExportAuthenticationCredentials
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13466
Change subject: [java] Deflake TestSecurity.testImportExportAuthenticationCredentials
......................................................................
[java] Deflake TestSecurity.testImportExportAuthenticationCredentials
This test was flaky for the same reason that
SecureKuduSinkTest.testEventsWithShortTickets was flaky (as addressed
in 3cbc025869494be2a1fa91582dfabc95d7bc88f9): the test was using short
ticket lifetimes, and sometimes in TSAN the cluster would simply take
longer than the ticket lifetime to start, causing the minicluster
check to fail with "not authorized" errors. However, unlike the sink
test, I don't see a reason why this test needs to use short lifetimes.
It manually invalidates credentials and does not wait for expiration.
So, I simply unset the option making it use short ticket lifetimes.
Change-Id: Ifb9fd101deb82acc849ba5dd6dfe8a34a76eea03
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/13466/1
--
To view, visit http://gerrit.cloudera.org:8080/13466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb9fd101deb82acc849ba5dd6dfe8a34a76eea03
Gerrit-Change-Number: 13466
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [java] Deflake TestSecurity.testImportExportAuthenticationCredentials
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed a vote on this change.
Change subject: [java] Deflake TestSecurity.testImportExportAuthenticationCredentials
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ifb9fd101deb82acc849ba5dd6dfe8a34a76eea03
Gerrit-Change-Number: 13466
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] Deflake TestSecurity.testImportExportAuthenticationCredentials
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13466 )
Change subject: [java] Deflake TestSecurity.testImportExportAuthenticationCredentials
......................................................................
[java] Deflake TestSecurity.testImportExportAuthenticationCredentials
This test was flaky for the same reason that
SecureKuduSinkTest.testEventsWithShortTickets was flaky (as addressed
in 3cbc025869494be2a1fa91582dfabc95d7bc88f9): the test was using short
ticket lifetimes, and sometimes in TSAN the cluster would simply take
longer than the ticket lifetime to start, causing the minicluster
check to fail with "not authorized" errors. However, unlike the sink
test, I don't see a reason why this test needs to use short lifetimes.
It manually invalidates credentials and does not wait for expiration.
So, I simply unset the option making it use short ticket lifetimes.
Change-Id: Ifb9fd101deb82acc849ba5dd6dfe8a34a76eea03
Reviewed-on: http://gerrit.cloudera.org:8080/13466
Tested-by: Will Berkeley <wd...@gmail.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Will Berkeley: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb9fd101deb82acc849ba5dd6dfe8a34a76eea03
Gerrit-Change-Number: 13466
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [java] Deflake TestSecurity.testImportExportAuthenticationCredentials
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13466 )
Change subject: [java] Deflake TestSecurity.testImportExportAuthenticationCredentials
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb9fd101deb82acc849ba5dd6dfe8a34a76eea03
Gerrit-Change-Number: 13466
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 30 May 2019 07:29:51 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Deflake TestSecurity.testImportExportAuthenticationCredentials
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13466 )
Change subject: [java] Deflake TestSecurity.testImportExportAuthenticationCredentials
......................................................................
Patch Set 1: Verified+1
Flakes -.-
--
To view, visit http://gerrit.cloudera.org:8080/13466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb9fd101deb82acc849ba5dd6dfe8a34a76eea03
Gerrit-Change-Number: 13466
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 30 May 2019 07:10:07 +0000
Gerrit-HasComments: No