[GitHub] [trafficcontrol] rob05c opened a new issue #3515: Refactor Traffic Ops Golang parent.config

[GitBox <gi...@apache.org>]

rob05c opened a new issue #3515: Refactor Traffic Ops Golang parent.config
URL: https://github.com/apache/trafficcontrol/issues/3515
 
 
   The Traffic Ops parent.config generation has been transliterated from Perl to Go:
   https://github.com/apache/trafficcontrol/pull/3075
   
   It's been transliterated as closely as possible, for safety. It's a very complex set of logic, and easy to get wrong, and getting it wrong can cause critical errors and potentially break traffic or even the entire CDN.
   
   The code needs refactored. There is much duplication, very long functions, querying too much data, and other issues.
   
   But, we don't want to completely refactor it at the same time as transliterating it, to reduce the risk of introducing errors.
   
   So, at some point after #3075 has been running without issue, we need to go back and improve it.
   
   When I transliterated it, I added `TODO` comments for all the issues I immediately saw. Those should be the starting point. But there are almost certainly other code sanity improvements that need to be made.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services