[jira] [Commented] (FLINK-10693) Fix Scala EitherSerializer duplication

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666114#comment-16666114 ] 

ASF GitHub Bot commented on FLINK-10693:
----------------------------------------

StephanEwen opened a new pull request #6951: [FLINK-10693] [Scala API] Fix incorrect duplication in EitherSerializer
URL: https://github.com/apache/flink/pull/6951
 
 
   ## What is the purpose of the change / Brief change log
   
   Fixes the duplication of the Scala `EitherSerialzer` that never deep copies, even though the nested serializers might require it.
   
   ## Verifying this change
   
     - Adds a self-contained unit test
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **yes**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix Scala EitherSerializer duplication
> --------------------------------------
>
>                 Key: FLINK-10693
>                 URL: https://issues.apache.org/jira/browse/FLINK-10693
>             Project: Flink
>          Issue Type: Bug
>          Components: Scala API
>    Affects Versions: 1.6.1
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> The Scala Either Serializer has buggy duplication logic, resulting in sharing and incorrect concurrent use when the nested serializers are not thread safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)