You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/05/02 00:36:25 UTC
Review Request 20991: Exposed event queue size to Process derived classes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20991/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
see summary
this will be used to allow Master and maybe Registrar to publish their libprocess event queue size to metrics.
Diffs
-----
3rdparty/libprocess/include/process/process.hpp d6bdccfccaad79cc9bc29f03a6cb9fa8550ccc64
Diff: https://reviews.apache.org/r/20991/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20991: Added protected access to event queue length.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20991/#review42078
-----------------------------------------------------------
Ship it!
I'll get this committed with the changes below.
3rdparty/libprocess/include/process/process.hpp
<https://reviews.apache.org/r/20991/#comment75823>
This needs some locking, I chatted with benh around an alternative approach:
-Expose 'events', 'lock()', 'unlock()' as protected.
-In the Master, have the Gauge read 'events.size()' in a locked section.
We were thinking about this, because there have been cases in the past where we wanted to introspect on the event queue.
- Ben Mahler
On May 2, 2014, 9:15 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20991/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 9:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
> this will be used to allow Master and maybe Registrar to publish their libprocess event queue size to metrics.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/process.hpp d6bdccfccaad79cc9bc29f03a6cb9fa8550ccc64
>
> Diff: https://reviews.apache.org/r/20991/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20991: Added protected access to event queue length.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20991/
-----------------------------------------------------------
(Updated May 2, 2014, 2:15 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
fixed up comment and method name style.
Summary (updated)
-----------------
Added protected access to event queue length.
Repository: mesos-git
Description
-------
see summary
this will be used to allow Master and maybe Registrar to publish their libprocess event queue size to metrics.
Diffs (updated)
-----
3rdparty/libprocess/include/process/process.hpp d6bdccfccaad79cc9bc29f03a6cb9fa8550ccc64
Diff: https://reviews.apache.org/r/20991/diff/
Testing
-------
make check
Thanks,
Dominic Hamon