[jira] [Comment Edited] (PYLUCENE-55) JCC creates the classes in non-deterministic order

["Andreas Vajda (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PYLUCENE-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179215#comment-17179215 ] 

Andreas Vajda edited comment on PYLUCENE-55 at 8/17/20, 8:40 PM:
-----------------------------------------------------------------

Can you be more specific about "not working" ?
Why does the order of classes matter ?
As it is, why should I accept your patch, maybe someone else is depending on the order to be random,
or the reverse of yours ? Seriously, I'd like to better understand what is going on here.
Please, help me help you by:
  - describing or quoting the error, "not working" is not good enough.
  - include a way to reproduce this, with your complete JCC command line.
There has to go be something more broken here than what the sorted order you're proposing is hiding.
Thanks !


was (Author: vajda):
Can you be more specific about "not working" ?
Why does the order of classes matter ?
As it is, why should I accept your patch, maybe someone else is depending on the order to be random,
or the reverse of yours ? Seriously, I'd like to better understand what is going on here.
Please, help me help you by:
  - describing or quoting the error, "not working" is not good enough.
  - include a way to reproduce this, with your complete JCC command line.
There has to go be something more broken here than that the sorted order you're proposing is hiding.
Thanks !

> JCC creates the classes in non-deterministic order
> --------------------------------------------------
>
>                 Key: PYLUCENE-55
>                 URL: https://issues.apache.org/jira/browse/PYLUCENE-55
>             Project: PyLucene
>          Issue Type: Bug
>            Reporter: Andrea Sterbini
>            Priority: Major
>
> I am trying to wrap the BabelNet API code.
> The resulting module is non-deterministically not-working (once every 5 I get it OK).
> This seems to be related to the order the classes are handled, because they are kept in a set, which has nondeterministic order.
> By changing cpp.py at line 696 to sort the class names I get a working module.
> {code:java}
> // changed from
> for cls in todo:
> {code}
> {code:java}
> // to
> for cls in sorted(todo, key=lambda c: c.getName()):{code}
> I have been luky with this way to order the classes. Possibly a better algorithm exists to fix this bug. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)