You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/10/23 07:09:27 UTC
[jira] [Commented] (CB-9702) Fix plugin initialization based on
XCode 7.0 compiler warnings
[ https://issues.apache.org/jira/browse/CB-9702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970449#comment-14970449 ]
ASF subversion and git services commented on CB-9702:
-----------------------------------------------------
Commit 1132a185666fb60acdcddfa801d59525a8535d38 in cordova-plugin-network-information's branch refs/heads/master from [~purplecabbage]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-network-information.git;h=1132a18 ]
Merge branch 'CB-9702' of https://github.com/pstoll/cordova-plugin-network-information
> Fix plugin initialization based on XCode 7.0 compiler warnings
> --------------------------------------------------------------
>
> Key: CB-9702
> URL: https://issues.apache.org/jira/browse/CB-9702
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Network Information
> Affects Versions: Master
> Environment: XCode Version 7.0 (7A220)
> Reporter: Perry Stoll
>
> xcode complains "These will always evaluate to true", which, looking at these lines, makes sense. These things are objects, taking their address will always yield a non-null value.
> {code}
> cordova-plugin-network-information pstoll$ git diff
> diff --git a/src/ios/CDVConnection.m b/src/ios/CDVConnection.m
> index 3749767..223dd7c 100644
> --- a/src/ios/CDVConnection.m
> +++ b/src/ios/CDVConnection.m
> @@ -118,7 +118,7 @@
> [self.internetReach startNotifier];
> [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(updateConnectionType:)
> name:kReachabilityChangedNotification object:nil];
> - if (&UIApplicationDidEnterBackgroundNotification && &UIApplicationWillEnterForegroundNotification) {
> + if (UIApplicationDidEnterBackgroundNotification && UIApplicationWillEnterForegroundNotification) {
> [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(onPause) name:UIApplicationDidEnterBackgroundNotification object:nil];
> [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(onResume) name:UIApplicationWillEnterForegroundNotification object:nil];
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org