[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4201: [TE] Update anomaly merge logic

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #4201: [TE] Update anomaly merge logic
URL: https://github.com/apache/incubator-pinot/pull/4201#discussion_r283062076
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/MergeWrapper.java
 ##########
 @@ -163,46 +171,81 @@ public DetectionPipelineResult run() throws Exception {
       MergedAnomalyResultDTO parent = parents.get(key);
 
       if (parent == null || anomaly.getStartTime() - parent.getEndTime() > this.maxGap) {
-        // no parent, too far away
+        // no parent, too far away to merge
+        //      parent |-------------|
 
 Review comment:
   Nice comments!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org