You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/05/09 20:27:31 UTC

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14912: Add fp16 and fp64 support for topk

anirudh2290 commented on a change in pull request #14912: Add fp16 and fp64 support for topk
URL: https://github.com/apache/incubator-mxnet/pull/14912#discussion_r282652182
 
 

 ##########
 File path: src/operator/tensor/ordering_op-inl.h
 ##########
 @@ -401,8 +401,6 @@ void TopKImpl(const RunContext &ctx,
     mxnet::op::SortByKeyWorkspaceSize<int, int, xpu>(src.Size()));
   temp_size = std::max(temp_size,
     mxnet::op::SortByKeyWorkspaceSize<int, DType, xpu>(src.Size()));
-  temp_size = std::max(temp_size,
-    mxnet::op::SortByKeyWorkspaceSize<DType, int, xpu>(src.Size()));
 
 Review comment:
   have you tried other dtypes like int64 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services