You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "anishmehta24 (via GitHub)" <gi...@apache.org> on 2026/09/20 11:46:34 UTC

[PR] GH-4240: GROUP_CONCAT(DISTINCT) over an empty group is the empty string [jena]

anishmehta24 opened a new pull request, #4243:
URL: https://github.com/apache/jena/pull/4243

   GitHub issue resolved #4240
   
   Pull request Description:
   
   `AggGroupConcatDistinct.getValueEmpty()` returned `null`, so `GROUP_CONCAT(DISTINCT ?v)` over an empty group (a query with no `GROUP BY` and no matching solutions) left the aggregate variable unbound. The non-DISTINCT `AggGroupConcat` already returns `NodeConst.emptyString`, which is what the SPARQL definition of GroupConcat gives for an empty multiset. This makes the DISTINCT form do the same.
   
   Test: a scripted query in `testing/ARQ/Extra` (`group-concat-distinct-empty`) running both forms over an empty graph and expecting `""` for each; it fails on `main` and passes with the change. The full `Scripts_ARQ` suite passes (309 tests).
   
   ----
   
    - [x] Tests are included.
    - [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/) (not needed)
    - [x] Commits have been squashed to remove intermediate development commit messages.
    - [x] Key commit messages start with the issue number (GH-xxxx)
   
   By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] GH-4240: GROUP_CONCAT(DISTINCT) over an empty group is the empty string [jena]

Posted by "anishmehta24 (via GitHub)" <gi...@apache.org>.
anishmehta24 commented on PR #4243:
URL: https://github.com/apache/jena/pull/4243#issuecomment-5980251296

   @afs gentle ping on this one, and #4245, #4246, #4247 when you have time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] GH-4240: GROUP_CONCAT(DISTINCT) over an empty group is the empty string [jena]

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #4243:
URL: https://github.com/apache/jena/pull/4243#issuecomment-6015843381

   @anishmehta24 Reviewing takes time, and doesn't always happen in FIFO order.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org