[GitHub] [incubator-kyuubi] deadwind4 commented on a diff in pull request #2446: [KYUUBI #2433] HiveSQLEngine load required jars from HIVE_HADOOP_CLASSPATH

[GitBox <gi...@apache.org>]

deadwind4 commented on code in PR #2446:
URL: https://github.com/apache/incubator-kyuubi/pull/2446#discussion_r857280810


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/hive/HiveProcessBuilder.scala:
##########
@@ -39,6 +39,8 @@ class HiveProcessBuilder(
 
   private val hiveHome: String = getEngineHome("hive")
 
+  private val HIVE_HADOOP_CLASSPATH: String = "HIVE_HADOOP_CLASSPATH"

Review Comment:
   It's usefull. I change all "HIVE_HADOOP_CLASSPATH" literal to this constant. In the future, we could move all similar constants to a scala file.
   
   The following code uses this constant.
   https://github.com/deadwind4/incubator-kyuubi/blob/9f9fcdac5b6f77eb03e20d6e41f95b03a1dc9568/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/hive/HiveProcessBuilder.scala#L82-L95



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org