You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/26 09:03:26 UTC

[GitHub] [airflow] ashb commented on a diff in pull request #25173: Improve taskflow type hints with ParamSpec

ashb commented on code in PR #25173:
URL: https://github.com/apache/airflow/pull/25173#discussion_r929710911


##########
airflow/providers/salesforce/operators/bulk.py:
##########
@@ -47,7 +47,7 @@ class SalesforceBulkOperator(BaseOperator):
     def __init__(
         self,
         *,
-        operation: Literal[available_operations],
+        operation: Literal['insert', 'update', 'upsert', 'delete', 'hard_delete'],

Review Comment:
   Is it not possible to do 
   ```suggestion
           operation: Literal[*available_operations],
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org