You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/29 15:35:57 UTC
[GitHub] [flink] godfreyhe commented on a change in pull request #13839: [FLINK-19628][table-planner] Introduce multiple input operator for streaming
godfreyhe commented on a change in pull request #13839:
URL: https://github.com/apache/flink/pull/13839#discussion_r514356134
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperatorV2.java
##########
@@ -93,8 +93,8 @@
protected final LatencyStats latencyStats;
protected final ProcessingTimeService processingTimeService;
- private StreamOperatorStateHandler stateHandler;
- private InternalTimeServiceManager<?> timeServiceManager;
+ protected StreamOperatorStateHandler stateHandler;
+ protected InternalTimeServiceManager<?> timeServiceManager;
Review comment:
Thanks for the suggestion. I find `AbstractStreamOperatorV2` has already provided a protected method named `getTimeServiceManager`. We can also add a `protected` method named `getStateHandler`. So that its sub-classes can access `stateHandler` and `timeServiceManager` both. I will revert the previous change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org