[jira] [Commented] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952537#comment-15952537 ] 

ASF GitHub Bot commented on THRIFT-3112:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/500
  
    @jfarrell this is closed/fixed in Jira.  This PR can be closed.


> [Java] AsyncMethodCallback should be typed in generated AsyncIface
> ------------------------------------------------------------------
>
>                 Key: THRIFT-3112
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3112
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler, Java - Library
>    Affects Versions: 0.9.2, 0.9.3
>            Reporter: Sergei Egorov
>            Assignee: John Sirois
>             Fix For: 0.10.0
>
>
> AsyncMethodCallback is generic, but current Java code generator is not adding type info to it, and instead of:
> {code:java}
> public interface AsyncIface {
>     public void ping(org.apache.thrift.async.AsyncMethodCallback<String> resultHandler) throws org.apache.thrift.TException;
>  }
> {code}
> we have:
> {code:java}
> public interface AsyncIface {
>     public void ping(org.apache.thrift.async.AsyncMethodCallback resultHandler) throws org.apache.thrift.TException;
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)