You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/03 19:05:59 UTC
[GitHub] [tvm] mbaret opened a new pull request, #11203: [TENSORRT] Improvements and fixes for TensorRT
mbaret opened a new pull request, #11203:
URL: https://github.com/apache/tvm/pull/11203
A number of small fixes and refactors to improve the robustness of the TensorRT integration.
Co-authored-by: Mark Shields <mb...@octoml.ai>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tiandiao123 commented on pull request #11203: [TENSORRT] Improvements and fixes for TensorRT
Posted by GitBox <gi...@apache.org>.
tiandiao123 commented on PR #11203:
URL: https://github.com/apache/tvm/pull/11203#issuecomment-1151619297
nice job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm merged pull request #11203: [TENSORRT] Improvements and fixes for TensorRT
Posted by GitBox <gi...@apache.org>.
jwfromm merged PR #11203:
URL: https://github.com/apache/tvm/pull/11203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbaret commented on pull request #11203: [TENSORRT] Improvements and fixes for TensorRT
Posted by GitBox <gi...@apache.org>.
mbaret commented on PR #11203:
URL: https://github.com/apache/tvm/pull/11203#issuecomment-1117368986
Unfortunately, the attributes aren't particularly well-defined. For example, in that specific test it was failing with channels between 28 and 45. I think so long as TensorRT is selecting strategies with different numerical behaviour based on tuning we won't be able to give a sane warning here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mikepapadim commented on pull request #11203: [TENSORRT] Improvements and fixes for TensorRT
Posted by GitBox <gi...@apache.org>.
mikepapadim commented on PR #11203:
URL: https://github.com/apache/tvm/pull/11203#issuecomment-1118317834
LGTM, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbs-octoml commented on pull request #11203: [TENSORRT] Improvements and fixes for TensorRT
Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on PR #11203:
URL: https://github.com/apache/tvm/pull/11203#issuecomment-1117653459
Ack. We do what we can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbaret commented on pull request #11203: [TENSORRT] Improvements and fixes for TensorRT
Posted by GitBox <gi...@apache.org>.
mbaret commented on PR #11203:
URL: https://github.com/apache/tvm/pull/11203#issuecomment-1117328021
cc @mbs-octoml @mikepapadim
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbs-octoml commented on pull request #11203: [TENSORRT] Improvements and fixes for TensorRT
Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on PR #11203:
URL: https://github.com/apache/tvm/pull/11203#issuecomment-1117360408
The background on the bits I fiddled with:
- Finish the transition from operator predicate based to pattern based for the partition_for_tensorrt function. The current state in main is broken.
- Remove choice of operator vs predicate method since they are indistinguishable from the outside.
- Though most operators can be translated looking only at the operator call, nn.batch_norm can only be translated in the form of a sub-graph `nn.batch_norm(...).0`. So switch the translation to follow the standard composite style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org