You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Henri Yandell (JIRA)" <ji...@apache.org> on 2010/01/16 09:24:54 UTC
[jira] Commented: (LANG-564) StrLookup API is confused
[ https://issues.apache.org/jira/browse/LANG-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801123#action_12801123 ]
Henri Yandell commented on LANG-564:
------------------------------------
The class is for providing a Str, Str view on a Str, V storage. From the tests:
{code:java}
Map<String, Object> map = new HashMap<String, Object>();
map.put("number", new Integer(2));
assertEquals("2", StrLookup.mapLookup(map).lookup("number"));
{code}
Based on that, the genercizing looks good to me (yeah I know I'm contradicting my previous comment, I hadn't dug into the previous code). I think a bit more javadoc explanation is in need but not a generics change.
> StrLookup API is confused
> -------------------------
>
> Key: LANG-564
> URL: https://issues.apache.org/jira/browse/LANG-564
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.text.*
> Reporter: Sebb
> Fix For: 3.0
>
>
> The API for StrLookup is confused. The class has been partly genericised, but why?
> The Javadoc says the class is for looking up Strings which are indexed by Strings, and this agrees with the method lookup()
> Surely if the class is generic on <V>, the lookup() method should return V, not String?
> Does it make any sense for the class to return anything but a String? If not, then why is the class generic?
> If it does make sense, then lookup() should return V.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.