You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2022/07/14 09:29:16 UTC

[incubator-kyuubi] branch master updated: [KYUUBI #3073] CredentialsManager should use appUser to renew credential

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 82d61c9fa [KYUUBI #3073] CredentialsManager should use appUser to renew credential
82d61c9fa is described below

commit 82d61c9fa92573ba52c83cbca282908fa81cfa21
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Thu Jul 14 17:29:06 2022 +0800

    [KYUUBI #3073] CredentialsManager should use appUser to renew credential
    
    ### _Why are the changes needed?_
    
    CredentialsManager should use appUser to renew credentials instead of session user.
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #3073 from pan3793/renew.
    
    Closes #3073
    
    4938fb3e [Cheng Pan] CredentialsManager should use appUser to renew credential
    
    Authored-by: Cheng Pan <ch...@apache.org>
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 .../src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala
index 667d86ac8..e515d7146 100644
--- a/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala
+++ b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala
@@ -177,7 +177,7 @@ class KyuubiSessionImpl(
 
   private def renewEngineCredentials(): String = {
     try {
-      sessionManager.credentialsManager.renewCredentials(user)
+      sessionManager.credentialsManager.renewCredentials(engine.appUser)
     } catch {
       case e: Exception =>
         error(s"Failed to renew engine credentials for $handle", e)