[jira] [Commented] (ORC-183) [C++] Add a method in Type to build type from string

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995262#comment-15995262 ] 

ASF GitHub Bot commented on ORC-183:
------------------------------------

Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/115#discussion_r114603588
  
    --- Diff: c++/src/TypeImpl.cc ---
    @@ -491,4 +491,190 @@ namespace orc {
         return std::unique_ptr<Type>(result);
       }
     
    +  Type * Type::buildTypeFromString(const std::string& input) {
    --- End diff --
    
    This should probably be factored in to smaller functions. Take a look at the equivalent java https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/TypeDescription.java#L396 and you'll see parseName, parseCategory, parseInteger, etc.


> [C++] Add a method in Type to build type from string
> ----------------------------------------------------
>
>                 Key: ORC-183
>                 URL: https://issues.apache.org/jira/browse/ORC-183
>             Project: ORC
>          Issue Type: Sub-task
>          Components: C++
>            Reporter: Gang Wu
>            Assignee: Gang Wu
>
> Currently Type class only supports building type like a container. It will be much easier to create type from a string.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)