You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/12 17:39:53 UTC

[GitHub] [ignite] artnaseef opened a new pull request, #10196: IGNITE-17524 Improve lookup of deployed services UUID by name: replac…

artnaseef opened a new pull request, #10196:
URL: https://github.com/apache/ignite/pull/10196

   …e list lookup with map lookup.
   
   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ignite] artnaseef commented on pull request #10196: IGNITE-17524 Improve lookup of deployed services UUID by name: replac…

Posted by GitBox <gi...@apache.org>.
artnaseef commented on PR #10196:
URL: https://github.com/apache/ignite/pull/10196#issuecomment-1213363328

   The purpose (WHY) of this change is to improve service shutdown performance (in local testing 60,000 services, shutdown time dropped from around 60 seconds to around 1 second).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ignite] ptupitsyn merged pull request #10196: IGNITE-17524 Improve lookup of deployed services UUID by name: replace list lookup with map lookup

Posted by GitBox <gi...@apache.org>.
ptupitsyn merged PR #10196:
URL: https://github.com/apache/ignite/pull/10196


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ignite] artnaseef commented on pull request #10196: IGNITE-17524 Improve lookup of deployed services UUID by name: replac…

Posted by GitBox <gi...@apache.org>.
artnaseef commented on PR #10196:
URL: https://github.com/apache/ignite/pull/10196#issuecomment-1213362348

   The changes are similar to those of IGNITE-17274.  A new map is added to track the registered service-names mapped to the service-info structure.  The lookup is changed from a linear lookup of the `deployedService.values()` structure to a `get` on the new map.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org