You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/01/19 20:25:46 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP-997 - Feature and Feat...
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/205
TINKERPOP-997 - Feature and FeatureRequirement adjustments
As they were very closely related, this PR covers:
https://issues.apache.org/jira/browse/TINKERPOP-997
https://issues.apache.org/jira/browse/TINKERPOP-998
it deprecates a `Feature` that was basically a duplicate of another. It also opens up a good number of test cases to graphs that don't support meta-properties as there was a mis-definition of the `SIMPLE` requirement set.
Tested with `mvn clean install -DincludeNeo4j` and all was good. Also temporarily modified the TinkerGraph feature for meta-property support and manually noted that the right test cases opened up and closed down based on this change. Would be nice to get some verification from other graphs that this change is all good.
@jdellithorpe please take a look at this change when you get a moment, as you were the one who noted the problem in the first place. Looks like we get about 90 tests opened up as a result of this.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-997
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #205
----
commit cc6f10dbee050136729a407dd50b2c123729ebdb
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-01-19T17:53:56Z
TINKERPOP-998 Deprecated the VertexPropertyFeatures.FEATURE_ADD_PROPERTY.
Replaced by the already existing (duplicate) VertexFeatures.FEATURE_META_PROPERTIES.
commit 74cd88cede4439a93ec764fce623d4a499052336
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-01-19T18:58:28Z
TINKERPOP-997 FeatureRequirementSet.SIMPLE uses VertexFeatures.FEATURE_ADD_PROPERTY
This opens up a large number of tests in the test suite (about 90 or so) - providers may see some breakage as a result.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-997 - Feature and Feat...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/205#issuecomment-174046598
thanks @dkuppitz - the real test will be when providers start running their tests and stuff starts popping off. hopefully a few get a chance next week to try out all the tests that opened up as a result of these changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-997 - Feature and Feat...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/205#issuecomment-174044610
Just to make that time spent on integration tests not too worthless:
* `mvn clean install`: passed
* integration tests: passed
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-997 - Feature and Feat...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/205#issuecomment-173979930
Looks good. VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-997 - Feature and Feat...
Posted by jdellithorpe <gi...@git.apache.org>.
Github user jdellithorpe commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/205#issuecomment-174620611
This looks good to me. Just to be clear, now supporting meta-properties means specifically supporting the *addition* of meta-properties. Removing meta-properties is a separate feature, not implied by FEATURE_META_PROPERTIES.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-997 - Feature and Feat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-997 - Feature and Feat...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/205#issuecomment-174964582
yeah - we still have `VertexPropertyFeatures.supportsRemoveProperty()` hanging out there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-997 - Feature and Feat...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/205#issuecomment-173977199
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---