You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/16 22:43:36 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4392: Allow
customized metrics prefix in pinot controller/broker/server
codecov-io edited a comment on issue #4392: Allow customized metrics prefix in pinot controller/broker/server
URL: https://github.com/apache/incubator-pinot/pull/4392#issuecomment-507921757
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4392?src=pr&el=h1) Report
> Merging [#4392](https://codecov.io/gh/apache/incubator-pinot/pull/4392?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/33f583b2a84a8a22143a26c9cc6b80dc2a81563c?src=pr&el=desc) will **increase** coverage by `9.78%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4392?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4392 +/- ##
============================================
+ Coverage 55.7% 65.49% +9.78%
Complexity 20 20
============================================
Files 1066 1076 +10
Lines 55403 55911 +508
Branches 7894 7975 +81
============================================
+ Hits 30865 36617 +5752
+ Misses 22150 16663 -5487
- Partials 2388 2631 +243
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4392?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/pinot/controller/ControllerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4392/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9Db250cm9sbGVyU3RhcnRlci5qYXZh) | `68.87% <ø> (+3.11%)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/pinot/controller/ControllerConf.java](https://codecov.io/gh/apache/incubator-pinot/pull/4392/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9Db250cm9sbGVyQ29uZi5qYXZh) | `49.72% <ø> (+2.96%)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4392/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `48.97% <ø> (+18.54%)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/pinot/server/starter/ServerBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4392/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9TZXJ2ZXJCdWlsZGVyLmphdmE=) | `82.5% <0%> (+82.5%)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/pinot/common/metrics/ControllerMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/4392/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Db250cm9sbGVyTWV0cmljcy5qYXZh) | `85.71% <100%> (+5.71%)` | `0 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/pinot/minion/MinionStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4392/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vTWluaW9uU3RhcnRlci5qYXZh) | `86.25% <100%> (+86.25%)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/pinot/common/metrics/BrokerMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/4392/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJNZXRyaWNzLmphdmE=) | `88.88% <100%> (+3.17%)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/pinot/server/conf/ServerConf.java](https://codecov.io/gh/apache/incubator-pinot/pull/4392/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvY29uZi9TZXJ2ZXJDb25mLmphdmE=) | `76.47% <100%> (+76.47%)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/pinot/minion/metrics/MinionMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/4392/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25NZXRyaWNzLmphdmE=) | `57.14% <33.33%> (+57.14%)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/pinot/broker/broker/BrokerServerBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4392/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0Jyb2tlclNlcnZlckJ1aWxkZXIuamF2YQ==) | `85.96% <50%> (+21.67%)` | `0 <0> (ø)` | :arrow_down: |
| ... and [370 more](https://codecov.io/gh/apache/incubator-pinot/pull/4392/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4392?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4392?src=pr&el=footer). Last update [33f583b...7276cb4](https://codecov.io/gh/apache/incubator-pinot/pull/4392?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org