You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/03/29 19:59:12 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #3976: Store Timezone as Arc

tustvold opened a new pull request, #3976:
URL: https://github.com/apache/arrow-rs/pull/3976

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Relates to #3955 
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   Timezones are very often constant over a large number of types, e.g. if part of a session global default timezone. Maintaining separate allocations for every timestamp is therefore incredibly wasteful. 
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #3976: Store Timezone as Arc

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3976:
URL: https://github.com/apache/arrow-rs/pull/3976#issuecomment-1489451176

   > Perhaps we could add convenience methods to construct these variants like
   
   I'd rather avoid these as it results in a slightly confused API surface, but I will add some documentation to the variant itself


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #3976: Store Timezone as Arc

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3976:
URL: https://github.com/apache/arrow-rs/pull/3976


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #3976: Store Timezone as Arc

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3976:
URL: https://github.com/apache/arrow-rs/pull/3976#issuecomment-1489275213

   This, combined with #3965 and corresponding changes to the Union DataType we can get `DataType` down from 56 bytes to 24


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #3976: Store Timezone as Arc

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #3976:
URL: https://github.com/apache/arrow-rs/pull/3976#issuecomment-1490244501

   >  I'd rather avoid these as it results in a slightly confused API surface, but I will add some documentation to the variant itself
   
   Adding docs is a good start -- and we can always add a new method in the future if that would help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org