You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/05/04 06:36:46 UTC
Review Request 58984: Ambari Views are failing to compile in 2.4.3
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Yusaku Sako.
Bugs: AMBARI-20928
https://issues.apache.org/jira/browse/AMBARI-20928
Repository: ambari
Description
-------
npm package manager have been replaced with yarn manager and front-end plugins, node versions have been updated as per the requirements.
Diffs
-----
contrib/views/capacity-scheduler/pom.xml 181deb4
contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672
contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/files/pom.xml 8e691b1
contrib/views/files/src/main/resources/ui/package.json 24da458
contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/hawq/pom.xml e4ed54a
contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/hive-next/pom.xml a1e116d
contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2
contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
contrib/views/hive/pom.xml de83dbc
contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff
contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2
contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
contrib/views/hueambarimigration/pom.xml f7a42dd
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 64b3270
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION
contrib/views/jobs/pom.xml a8f44f3
contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/pig/pom.xml cf2ed37
contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483
contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION
contrib/views/pom.xml 0a1a77f
contrib/views/wfmanager/pom.xml bcb9572
contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c
contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION
pom.xml db3d457
Diff: https://reviews.apache.org/r/58984/diff/1/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 58984: Ambari Views are failing to compile in 2.4.3
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/#review173882
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On May 4, 2017, 6:36 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58984/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 6:36 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-20928
> https://issues.apache.org/jira/browse/AMBARI-20928
>
>
> Repository: ambari
>
>
> Description
> -------
>
> npm package manager have been replaced with yarn manager and front-end plugins, node versions have been updated as per the requirements.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/pom.xml 181deb4
> contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672
> contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/files/pom.xml 8e691b1
> contrib/views/files/src/main/resources/ui/package.json 24da458
> contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hawq/pom.xml e4ed54a
> contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hive-next/pom.xml a1e116d
> contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
> contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2
> contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
> contrib/views/hive/pom.xml de83dbc
> contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff
> contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2
> contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
> contrib/views/hueambarimigration/pom.xml f7a42dd
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 64b3270
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION
> contrib/views/jobs/pom.xml a8f44f3
> contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/pig/pom.xml cf2ed37
> contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483
> contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION
> contrib/views/pom.xml 0a1a77f
> contrib/views/wfmanager/pom.xml bcb9572
> contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c
> contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION
> pom.xml db3d457
>
>
> Diff: https://reviews.apache.org/r/58984/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 58984: Ambari Views are failing to compile in 2.4.3
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/
-----------------------------------------------------------
(Updated May 5, 2017, 3:42 a.m.)
Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-20928
https://issues.apache.org/jira/browse/AMBARI-20928
Repository: ambari
Description
-------
npm package manager have been replaced with yarn manager and front-end plugins, node versions have been updated as per the requirements.
Diffs (updated)
-----
contrib/views/capacity-scheduler/pom.xml 181deb4
contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672
contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/files/pom.xml 8e691b1
contrib/views/files/src/main/resources/ui/package.json 24da458
contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/hawq/pom.xml e4ed54a
contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/hive-next/pom.xml a1e116d
contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2
contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
contrib/views/hive/pom.xml de83dbc
contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff
contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2
contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
contrib/views/hueambarimigration/pom.xml f7a42dd
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 64b3270
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION
contrib/views/jobs/pom.xml a8f44f3
contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION
contrib/views/pig/pom.xml cf2ed37
contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483
contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION
contrib/views/pom.xml 0a1a77f
contrib/views/wfmanager/pom.xml bcb9572
contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c
contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION
pom.xml db3d457
Diff: https://reviews.apache.org/r/58984/diff/2/
Changes: https://reviews.apache.org/r/58984/diff/1-2/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 58984: Ambari Views are failing to compile in 2.4.3
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/#review173881
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On May 4, 2017, 6:36 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58984/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 6:36 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-20928
> https://issues.apache.org/jira/browse/AMBARI-20928
>
>
> Repository: ambari
>
>
> Description
> -------
>
> npm package manager have been replaced with yarn manager and front-end plugins, node versions have been updated as per the requirements.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/pom.xml 181deb4
> contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672
> contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/files/pom.xml 8e691b1
> contrib/views/files/src/main/resources/ui/package.json 24da458
> contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hawq/pom.xml e4ed54a
> contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hive-next/pom.xml a1e116d
> contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
> contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2
> contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
> contrib/views/hive/pom.xml de83dbc
> contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff
> contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2
> contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
> contrib/views/hueambarimigration/pom.xml f7a42dd
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 64b3270
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION
> contrib/views/jobs/pom.xml a8f44f3
> contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/pig/pom.xml cf2ed37
> contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483
> contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION
> contrib/views/pom.xml 0a1a77f
> contrib/views/wfmanager/pom.xml bcb9572
> contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c
> contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION
> pom.xml db3d457
>
>
> Diff: https://reviews.apache.org/r/58984/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 58984: Ambari Views are failing to compile in 2.4.3
Posted by venkat sairam <ve...@gmail.com>.
> On May 4, 2017, 4:49 p.m., Yusaku Sako wrote:
> > contrib/views/files/pom.xml
> > Lines 183 (patched)
> > <https://reviews.apache.org/r/58984/diff/1/?file=1708165#file1708165line183>
> >
> > I tested the patch locally.
> >
> > This is a general comment that applies to all pom.xml file changes.
> > We can't have two arguments tags here like this, because the last one will overwrite the first one. So essentially, yarn is being run with "yarn --ignore-engines".
> >
> > Also, --pure-lockfile argument is missing in this particular pom.xml.
The --pure-lockfile argument is present in files/pom.xml and the arguments tag have been fixed in the similar manner how other tags are written.
- venkat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/#review173924
-----------------------------------------------------------
On May 5, 2017, 3:42 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58984/
> -----------------------------------------------------------
>
> (Updated May 5, 2017, 3:42 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-20928
> https://issues.apache.org/jira/browse/AMBARI-20928
>
>
> Repository: ambari
>
>
> Description
> -------
>
> npm package manager have been replaced with yarn manager and front-end plugins, node versions have been updated as per the requirements.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/pom.xml 181deb4
> contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672
> contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/files/pom.xml 8e691b1
> contrib/views/files/src/main/resources/ui/package.json 24da458
> contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hawq/pom.xml e4ed54a
> contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hive-next/pom.xml a1e116d
> contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
> contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2
> contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
> contrib/views/hive/pom.xml de83dbc
> contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff
> contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2
> contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
> contrib/views/hueambarimigration/pom.xml f7a42dd
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 64b3270
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION
> contrib/views/jobs/pom.xml a8f44f3
> contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/pig/pom.xml cf2ed37
> contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483
> contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION
> contrib/views/pom.xml 0a1a77f
> contrib/views/wfmanager/pom.xml bcb9572
> contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c
> contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION
> pom.xml db3d457
>
>
> Diff: https://reviews.apache.org/r/58984/diff/2/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 58984: Ambari Views are failing to compile in 2.4.3
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/#review173924
-----------------------------------------------------------
In all the pom.xml's, there are two
contrib/views/files/pom.xml
Lines 183 (patched)
<https://reviews.apache.org/r/58984/#comment247003>
I tested the patch locally.
This is a general comment that applies to all pom.xml file changes.
We can't have two arguments tags here like this, because the last one will overwrite the first one. So essentially, yarn is being run with "yarn --ignore-engines".
Also, --pure-lockfile argument is missing in this particular pom.xml.
- Yusaku Sako
On May 4, 2017, 6:36 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58984/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 6:36 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-20928
> https://issues.apache.org/jira/browse/AMBARI-20928
>
>
> Repository: ambari
>
>
> Description
> -------
>
> npm package manager have been replaced with yarn manager and front-end plugins, node versions have been updated as per the requirements.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/pom.xml 181deb4
> contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672
> contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/files/pom.xml 8e691b1
> contrib/views/files/src/main/resources/ui/package.json 24da458
> contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hawq/pom.xml e4ed54a
> contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/hive-next/pom.xml a1e116d
> contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff
> contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2
> contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
> contrib/views/hive/pom.xml de83dbc
> contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff
> contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2
> contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION
> contrib/views/hueambarimigration/pom.xml f7a42dd
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 64b3270
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION
> contrib/views/jobs/pom.xml a8f44f3
> contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION
> contrib/views/pig/pom.xml cf2ed37
> contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483
> contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION
> contrib/views/pom.xml 0a1a77f
> contrib/views/wfmanager/pom.xml bcb9572
> contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c
> contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION
> pom.xml db3d457
>
>
> Diff: https://reviews.apache.org/r/58984/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>