You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/12/02 18:17:50 UTC
[GitHub] [trafficserver] brbzull0 opened a new pull request #7367: Fix FreeBSD 12 link issue in test_libhttp2.
brbzull0 opened a new pull request #7367:
URL: https://github.com/apache/trafficserver/pull/7367
Change the order or library includes. This was already fix and re-worked after which seems to break it. It should now work ok again.
```
89dccb5cf8 Follow the comments in I_Thread.h, add an independent ink_thread_key for EThread. (#6288)
3a6f49b054 Fix link issue of test_libhttp2 on FreeBSD 12 with --enable-debug
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7367: Fix FreeBSD 12 link issue in test_libhttp2.
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7367:
URL: https://github.com/apache/trafficserver/pull/7367#issuecomment-738885023
Interesting enough the FreeBSD 12 builds are not broken on 8.x and 9.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #7367: Fix FreeBSD 12 link issue in test_libhttp2.
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on pull request #7367:
URL: https://github.com/apache/trafficserver/pull/7367#issuecomment-738892250
8.x and 9.x are fine as they both have the first fix(#6666) 10.master is broken apparently after #6288
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #7367: Fix FreeBSD 12 link issue in test_libhttp2.
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on pull request #7367:
URL: https://github.com/apache/trafficserver/pull/7367#issuecomment-737898146
[approve ci Ubuntu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt removed a comment on pull request #7367: Fix FreeBSD 12 link issue in test_libhttp2.
Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #7367:
URL: https://github.com/apache/trafficserver/pull/7367#issuecomment-738238169
I assume that since #6666 went to 8.x, this is needed for 8.x, 9.x, and master. Marking the projects milestone for this PR as such.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit merged pull request #7367: Fix FreeBSD 12 link issue in test_libhttp2.
Posted by GitBox <gi...@apache.org>.
maskit merged pull request #7367:
URL: https://github.com/apache/trafficserver/pull/7367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7367: Fix FreeBSD 12 link issue in test_libhttp2.
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7367:
URL: https://github.com/apache/trafficserver/pull/7367#issuecomment-738238169
I assume that since #6666 went to 8.x, this is needed for 8.x, 9.x, and master. Marking the projects milestone for this PR as such.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7367: Fix FreeBSD 12 link issue in test_libhttp2.
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7367:
URL: https://github.com/apache/trafficserver/pull/7367#issuecomment-739059917
@maskit Can you approve this as well? I'm fine with it, albeit wonky :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7367: Fix FreeBSD 12 link issue in test_libhttp2.
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7367:
URL: https://github.com/apache/trafficserver/pull/7367#issuecomment-738892805
> Interesting enough the FreeBSD 12 builds are not broken on 8.x and 9.x.
OK, thanks. I misunderstood the description. Damian confirmed that this is only broken in master, so I removed the 8 and 9 projects from the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org