You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/07/27 14:58:00 UTC

[jira] [Commented] (MENFORCER-301) banDuplicatePomDependencyVersions does not check managementDependencies

    [ https://issues.apache.org/jira/browse/MENFORCER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165762#comment-17165762 ] 

Hudson commented on MENFORCER-301:
----------------------------------

Build failed in Jenkins: Maven » Maven TLP » maven-enforcer » master #6

See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-enforcer/job/master/6/

> banDuplicatePomDependencyVersions does not check managementDependencies
> -----------------------------------------------------------------------
>
>                 Key: MENFORCER-301
>                 URL: https://issues.apache.org/jira/browse/MENFORCER-301
>             Project: Maven Enforcer Plugin
>          Issue Type: Bug
>          Components: Standard Rules
>    Affects Versions: 3.0.0-M1
>            Reporter: Alexander Kudrevatykh
>            Assignee: Sylwester Lachiewicz
>            Priority: Major
>             Fix For: 3.0.0
>
>
> MENFORCER-152 added rule for ban duplicate depndencies, but dependencyManagement section does not checked correctly
> code  {code:java} if ( model.getDependencyManagement() != null ) 
> {
>     List<Dependency> managementDependencies = model.getDependencies();
>     Map<String, Integer> duplicateManagementDependencies = validateDependencies( managementDependencies );{code} should be written as
> {code}
> if ( model.getDependencyManagement() != null ) 
> {
>     List<Dependency> managementDependencies = model.getDependencyManagement().getDependencies();
>     Map<String, Integer> duplicateManagementDependencies = validateDependencies( managementDependencies );{code} 
> and same fix should be applied to {noformat}profiles{noformat} checking code



--
This message was sent by Atlassian Jira
(v8.3.4#803005)