You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/25 14:20:08 UTC
[GitHub] [airflow] JonnyDaenen opened a new pull request #7260: Fix typo in
error for when getting dataflow jobs
JonnyDaenen opened a new pull request #7260: Fix typo in error for when getting dataflow jobs
URL: https://github.com/apache/airflow/pull/7260
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7260:
[AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7260: [AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs
URL: https://github.com/apache/airflow/pull/7260#issuecomment-578412985
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=h1) Report
> Merging [#7260](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/8325dd5507c95eca15a030b2aa5f3e6391734eb9?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7260 +/- ##
==========================================
- Coverage 85.33% 85.05% -0.28%
==========================================
Files 791 791
Lines 40137 40137
==========================================
- Hits 34251 34140 -111
- Misses 5886 5997 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=) | `88.37% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=footer). Last update [8325dd5...1fb23e3](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7260: [AIRFLOW-XXXX] Fix typo
in error when getting dataflow jobs
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7260: [AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs
URL: https://github.com/apache/airflow/pull/7260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7260:
[AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7260: [AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs
URL: https://github.com/apache/airflow/pull/7260#issuecomment-578555787
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] JonnyDaenen edited a comment on issue #7260:
[AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs
Posted by GitBox <gi...@apache.org>.
JonnyDaenen edited a comment on issue #7260: [AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs
URL: https://github.com/apache/airflow/pull/7260#issuecomment-578410485
Is there a way to easily change the commit message without creating a new fork/commit?
Also, how should I improve my commit message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7260: [AIRFLOW-XXXX] Fix
typo in error when getting dataflow jobs
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7260: [AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs
URL: https://github.com/apache/airflow/pull/7260#issuecomment-578412985
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=h1) Report
> Merging [#7260](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/8325dd5507c95eca15a030b2aa5f3e6391734eb9?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7260 +/- ##
==========================================
- Coverage 85.33% 85.05% -0.28%
==========================================
Files 791 791
Lines 40137 40137
==========================================
- Hits 34251 34140 -111
- Misses 5886 5997 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=) | `88.37% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7260/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=footer). Last update [8325dd5...1fb23e3](https://codecov.io/gh/apache/airflow/pull/7260?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj edited a comment on issue #7260: [AIRFLOW-XXXX]
Fix typo in error when getting dataflow jobs
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #7260: [AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs
URL: https://github.com/apache/airflow/pull/7260#issuecomment-578410808
You can also create a second commit using Github' Web UI. Then the warning will disappear. You should add "[JIRA-NNNN]" prefix to commit message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7260: Fix typo in
error for when getting dataflow jobs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7260: Fix typo in error for when getting dataflow jobs
URL: https://github.com/apache/airflow/pull/7260#issuecomment-578410035
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7260: [AIRFLOW-XXXX] Fix typo
in error when getting dataflow jobs
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7260: [AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs
URL: https://github.com/apache/airflow/pull/7260#issuecomment-578555868
Thanks @JonnyDaenen ! Just next time make sure the PR has [AIRFLOW-XXXX] prefix :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7260: [AIRFLOW-XXXX] Fix typo
in error when getting dataflow jobs
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7260: [AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs
URL: https://github.com/apache/airflow/pull/7260#issuecomment-578410808
You can also create a second commit using Github' Web UI. Then the warning will disappear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] JonnyDaenen commented on issue #7260: [AIRFLOW-XXXX] Fix
typo in error when getting dataflow jobs
Posted by GitBox <gi...@apache.org>.
JonnyDaenen commented on issue #7260: [AIRFLOW-XXXX] Fix typo in error when getting dataflow jobs
URL: https://github.com/apache/airflow/pull/7260#issuecomment-578410485
Is there a way to easily change the commit title without creating a new fork/commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services