[GitHub] ccollins476ad commented on a change in pull request #1375: [DO NOT MERGE] I2C retries - Driver

[GitBox <gi...@apache.org>]

ccollins476ad commented on a change in pull request #1375: [DO NOT MERGE] I2C retries - Driver
URL: https://github.com/apache/mynewt-core/pull/1375#discussion_r214743727
 
 

 ##########
 File path: hw/drivers/i2c/i2cn/include/i2cn/i2cn.h
 ##########
 @@ -0,0 +1,52 @@
+#ifndef H_I2CN_
+#define H_I2CN_
+
+#include <inttypes.h>
+#include "os/mynewt.h"
+struct hal_i2c_master_data;
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * @brief Reads from an I2C slave, retrying the specified number of times on
+ * failure.
+ *
+ * @param i2c_num               The index of the I2C interface to read from.
+ * @param pdata                 Additional parameters describing the read
+ *                                  operation.
+ * @param timeout               The time, in OS ticks, to wait for the MCU to
+ *                                  indicate completion of each clocked byte.
+ * @param last_op               1 if this is the final message in the
+ *                                  transaction.
+ *
 
 Review comment:
   Sigh... that would be a good idea, wouldn't it? :).  I have fixed this in a follow up commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services