[GitHub] [incubator-gobblin] jack-moseley commented on a change in pull request #3141: [GOBBLIN-1303] Catch error when failing to clean staging data

[GitBox <gi...@apache.org>]

jack-moseley commented on a change in pull request #3141:
URL: https://github.com/apache/incubator-gobblin/pull/3141#discussion_r514618204



##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -535,7 +535,11 @@ public WorkUnit apply(@Nullable WorkUnit input) {
       } finally {
         try {
           TimingEvent jobCleanupTimer = this.eventSubmitter.getTimingEvent(TimingEvent.LauncherTimings.JOB_CLEANUP);
-          cleanupStagingData(jobState);
+          try {
+            cleanupStagingData(jobState);
+          } catch (Throwable t) {
+            LOG.error("Failed to clean up staging data", t);

Review comment:
       Sure that's a good point, will change that




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org