You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Alexander Rukletsov (JIRA)" <ji...@apache.org> on 2018/08/21 06:50:00 UTC
[jira] [Commented] (MESOS-9158) Batch state-related read-only
requests in the Master actor.
[ https://issues.apache.org/jira/browse/MESOS-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587036#comment-16587036 ]
Alexander Rukletsov commented on MESOS-9158:
--------------------------------------------
{noformat}
commit a6c62980c012dc18cbcda475c59ddef46b5eb59b
Author: Benno Evers <be...@mesosphere.com>
AuthorDate: Tue Aug 21 08:09:54 2018 +0200
Commit: Alexander Rukletsov <al...@apache.org>
CommitDate: Tue Aug 21 08:09:54 2018 +0200
Added const versions of slave-counting functions in Master.
The family of functions '_slaves_active()', etc. is logically
const, although the function signatures do not currently
reflect this due to MESOS-4995.
Since a const version of this functionality is required for
the changes introduced in the subsequent commits, it is
added with different names as a workaround.
Review: https://reviews.apache.org/r/68342/
{noformat}
{noformat}
commit 943aa2c984bfab59e327e96e955a2de72b91218f
Author: Benno Evers <be...@mesosphere.com>
AuthorDate: Tue Aug 21 08:10:09 2018 +0200
Commit: Alexander Rukletsov <al...@apache.org>
CommitDate: Tue Aug 21 08:25:19 2018 +0200
Moved state serialization into separate function.
In preparation for the changes in the subsequent commit,
the serialization logic was moved from an inner lambda
to a separate function.
Review: https://reviews.apache.org/r/68343/
{noformat}
commit 8e2ea9d588440a054cb3e5ed9d72dd33985f7084
Author: Benno Evers <be...@mesosphere.com>
AuthorDate: Tue Aug 21 08:10:21 2018 +0200
Commit: Alexander Rukletsov <al...@apache.org>
CommitDate: Tue Aug 21 08:25:29 2018 +0200
Changed vector of requests to be mutable.
Changed the `batchedRequest` vector inside the `Master::Http`
class to be mutable, in order to be able to restore the
`const` qualifier to the `/state`-handler.
While this may be a debatable benefit for this
endpoint alone, the subsequent commits introduce
additional work to extend this mechanism to all
read-only endpoint of `Master`.
Without this change, this would create a paradoxical
situation where all mutating endpoints are marked as
const and all read-only endpoints are marked as
non-const.
Review: https://reviews.apache.org/r/68378/
{noformat}
{noformat}
commit c6c078e94865ad07abb4a12c5478a2bc46fc9eb4
Author: Benno Evers <be...@mesosphere.com>
AuthorDate: Tue Aug 21 08:10:38 2018 +0200
Commit: Alexander Rukletsov <al...@apache.org>
CommitDate: Tue Aug 21 08:25:29 2018 +0200
Added 'handler' field to batched requests.
This commit adds a handler field to be able to batch
arbitrary requests, instead of having a hard-coded
dispatch to `state`.
Review: https://reviews.apache.org/r/68296/
{noformat}
> Batch state-related read-only requests in the Master actor.
> -----------------------------------------------------------
>
> Key: MESOS-9158
> URL: https://issues.apache.org/jira/browse/MESOS-9158
> Project: Mesos
> Issue Type: Improvement
> Components: master
> Reporter: Alexander Rukletsov
> Assignee: Benno Evers
> Priority: Major
> Labels: mesosphere, performance
>
> Similar to MESOS-9122, make all read-only master state endpoints batched.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)