You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/09/05 15:21:57 UTC

[GitHub] [phoenix] stoty commented on pull request #1499: Phoenix 6728

stoty commented on PR #1499:
URL: https://github.com/apache/phoenix/pull/1499#issuecomment-1237200602

   I haven't looked at the actual code changes yet, but 
   1. Please change the commit message to conform to the conventions (see previous messages)
   2. Use rebase instead of merge to manage changes in master
   3. Undo the code reformats on lines that you haven't changed, they make finding and reviewing the actual changes difficult (ignore the Yetus errors for those)
   4. Remove unrelated first commit from PR (or fix name if it is related).
   5. There are a lot of Yetus errors, starting with compilation. Please fix those.
   
   You'll have to force-push the new version of the PR, that's ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org