You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/03 10:17:23 UTC

[GitHub] [incubator-shardingsphere] zjcnb opened a new pull request #4581: add ut for for sharding-orchestration-core module

zjcnb opened a new pull request #4581: add ut for  for sharding-orchestration-core module
URL: https://github.com/apache/incubator-shardingsphere/pull/4581
 
 
   For #4452

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4581: add ut for for sharding-orchestration-core module

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4581: add ut for  for sharding-orchestration-core module
URL: https://github.com/apache/incubator-shardingsphere/pull/4581#issuecomment-594314313
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=h1) Report
   > Merging [#4581](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/75c9b194f926072adca051acf6d7869211bcba09?src=pr&el=desc) will **decrease** coverage by `0.54%`.
   > The diff coverage is `44.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4581      +/-   ##
   ============================================
   - Coverage      54.8%   54.26%   -0.55%     
   - Complexity      327      343      +16     
   ============================================
     Files           967     1001      +34     
     Lines         18019    17985      -34     
     Branches       3406     3372      -34     
   ============================================
   - Hits           9875     9759     -116     
   - Misses         7509     7602      +93     
   + Partials        635      624      -11
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../text/sctl/show/ShardingCTLShowBackendHandler.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3RleHQvc2N0bC9zaG93L1NoYXJkaW5nQ1RMU2hvd0JhY2tlbmRIYW5kbGVyLmphdmE=) | `86.66% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...generator/impl/InsertCipherNameTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvSW5zZXJ0Q2lwaGVyTmFtZVRva2VuR2VuZXJhdG9yLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ypt/merge/dal/impl/EncryptColumnsMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1tZXJnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9tZXJnZS9kYWwvaW1wbC9FbmNyeXB0Q29sdW1uc01lcmdlZFJlc3VsdC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...frontend/mysql/auth/MySQLAuthenticationEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5ncHJveHkvZnJvbnRlbmQvbXlzcWwvYXV0aC9NeVNRTEF1dGhlbnRpY2F0aW9uRW5naW5lLmphdmE=) | `86.95% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...rding/rewrite/engine/ShardingSQLRewriteEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvZW5naW5lL1NoYXJkaW5nU1FMUmV3cml0ZUVuZ2luZS5qYXZh) | `83.33% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...gsphere/encrypt/merge/dql/EncryptMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1tZXJnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9tZXJnZS9kcWwvRW5jcnlwdE1lcmdlZFJlc3VsdC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...keygen/GeneratedKeyInsertColumnTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwva2V5Z2VuL0dlbmVyYXRlZEtleUluc2VydENvbHVtblRva2VuR2VuZXJhdG9yLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ine/type/unicast/ShardingUnicastRoutingEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJvdXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS9lbmdpbmUvdHlwZS91bmljYXN0L1NoYXJkaW5nVW5pY2FzdFJvdXRpbmdFbmdpbmUuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../rewrite/judgement/impl/SimpleJudgementEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhZG93LWNvcmUvc2hhZG93LWNvcmUtcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L3Jld3JpdGUvanVkZ2VtZW50L2ltcGwvU2ltcGxlSnVkZ2VtZW50RW5naW5lLmphdmE=) | `59.09% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ameter/impl/EncryptPredicateParameterRewriter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL2ltcGwvRW5jcnlwdFByZWRpY2F0ZVBhcmFtZXRlclJld3JpdGVyLmphdmE=) | `94.73% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
   | ... and [242 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=footer). Last update [75c9b19...4371b39](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4581: add ut for for sharding-orchestration-core module

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4581: add ut for  for sharding-orchestration-core module
URL: https://github.com/apache/incubator-shardingsphere/pull/4581#issuecomment-594315594
 
 
   ## Pull Request Test Coverage Report for [Build 10000](https://coveralls.io/builds/29117683)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.006%**) to **57.798%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29117683/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29117683/badge)](https://coveralls.io/builds/29117683) |
   | :-- | --: |
   | Change from base [Build 976](https://coveralls.io/builds/29097004): |  -0.006% |
   | Covered Lines: | 10395 |
   | Relevant Lines: | 17985 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4581: add ut for for sharding-orchestration-core module

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4581: add ut for  for sharding-orchestration-core module
URL: https://github.com/apache/incubator-shardingsphere/pull/4581#issuecomment-594314313
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=h1) Report
   > Merging [#4581](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/75c9b194f926072adca051acf6d7869211bcba09?src=pr&el=desc) will **decrease** coverage by `0.54%`.
   > The diff coverage is `44.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4581      +/-   ##
   ============================================
   - Coverage      54.8%   54.26%   -0.55%     
   - Complexity      327      343      +16     
   ============================================
     Files           967     1001      +34     
     Lines         18019    17985      -34     
     Branches       3406     3372      -34     
   ============================================
   - Hits           9875     9759     -116     
   - Misses         7509     7602      +93     
   + Partials        635      624      -11
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../text/sctl/show/ShardingCTLShowBackendHandler.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3RleHQvc2N0bC9zaG93L1NoYXJkaW5nQ1RMU2hvd0JhY2tlbmRIYW5kbGVyLmphdmE=) | `86.66% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...generator/impl/InsertCipherNameTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvSW5zZXJ0Q2lwaGVyTmFtZVRva2VuR2VuZXJhdG9yLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ypt/merge/dal/impl/EncryptColumnsMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1tZXJnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9tZXJnZS9kYWwvaW1wbC9FbmNyeXB0Q29sdW1uc01lcmdlZFJlc3VsdC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...frontend/mysql/auth/MySQLAuthenticationEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5ncHJveHkvZnJvbnRlbmQvbXlzcWwvYXV0aC9NeVNRTEF1dGhlbnRpY2F0aW9uRW5naW5lLmphdmE=) | `86.95% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...rding/rewrite/engine/ShardingSQLRewriteEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvZW5naW5lL1NoYXJkaW5nU1FMUmV3cml0ZUVuZ2luZS5qYXZh) | `83.33% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...gsphere/encrypt/merge/dql/EncryptMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1tZXJnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9tZXJnZS9kcWwvRW5jcnlwdE1lcmdlZFJlc3VsdC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...keygen/GeneratedKeyInsertColumnTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwva2V5Z2VuL0dlbmVyYXRlZEtleUluc2VydENvbHVtblRva2VuR2VuZXJhdG9yLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ine/type/unicast/ShardingUnicastRoutingEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJvdXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS9lbmdpbmUvdHlwZS91bmljYXN0L1NoYXJkaW5nVW5pY2FzdFJvdXRpbmdFbmdpbmUuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../rewrite/judgement/impl/SimpleJudgementEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhZG93LWNvcmUvc2hhZG93LWNvcmUtcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L3Jld3JpdGUvanVkZ2VtZW50L2ltcGwvU2ltcGxlSnVkZ2VtZW50RW5naW5lLmphdmE=) | `59.09% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ameter/impl/EncryptPredicateParameterRewriter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL2ltcGwvRW5jcnlwdFByZWRpY2F0ZVBhcmFtZXRlclJld3JpdGVyLmphdmE=) | `94.73% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
   | ... and [242 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=footer). Last update [75c9b19...4893695](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4581: add ut for for sharding-orchestration-core module

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4581: add ut for  for sharding-orchestration-core module
URL: https://github.com/apache/incubator-shardingsphere/pull/4581#issuecomment-594314313
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=h1) Report
   > Merging [#4581](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/75c9b194f926072adca051acf6d7869211bcba09?src=pr&el=desc) will **decrease** coverage by `0.54%`.
   > The diff coverage is `44.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4581      +/-   ##
   ============================================
   - Coverage      54.8%   54.26%   -0.55%     
   - Complexity      327      343      +16     
   ============================================
     Files           967     1001      +34     
     Lines         18019    17985      -34     
     Branches       3406     3372      -34     
   ============================================
   - Hits           9875     9759     -116     
   - Misses         7509     7602      +93     
   + Partials        635      624      -11
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../text/sctl/show/ShardingCTLShowBackendHandler.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3RleHQvc2N0bC9zaG93L1NoYXJkaW5nQ1RMU2hvd0JhY2tlbmRIYW5kbGVyLmphdmE=) | `86.66% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...generator/impl/InsertCipherNameTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvSW5zZXJ0Q2lwaGVyTmFtZVRva2VuR2VuZXJhdG9yLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ypt/merge/dal/impl/EncryptColumnsMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1tZXJnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9tZXJnZS9kYWwvaW1wbC9FbmNyeXB0Q29sdW1uc01lcmdlZFJlc3VsdC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...frontend/mysql/auth/MySQLAuthenticationEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5ncHJveHkvZnJvbnRlbmQvbXlzcWwvYXV0aC9NeVNRTEF1dGhlbnRpY2F0aW9uRW5naW5lLmphdmE=) | `86.95% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...rding/rewrite/engine/ShardingSQLRewriteEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvZW5naW5lL1NoYXJkaW5nU1FMUmV3cml0ZUVuZ2luZS5qYXZh) | `83.33% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...gsphere/encrypt/merge/dql/EncryptMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1tZXJnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9tZXJnZS9kcWwvRW5jcnlwdE1lcmdlZFJlc3VsdC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...keygen/GeneratedKeyInsertColumnTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwva2V5Z2VuL0dlbmVyYXRlZEtleUluc2VydENvbHVtblRva2VuR2VuZXJhdG9yLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ine/type/unicast/ShardingUnicastRoutingEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJvdXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS9lbmdpbmUvdHlwZS91bmljYXN0L1NoYXJkaW5nVW5pY2FzdFJvdXRpbmdFbmdpbmUuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../rewrite/judgement/impl/SimpleJudgementEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-c2hhZG93LWNvcmUvc2hhZG93LWNvcmUtcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L3Jld3JpdGUvanVkZ2VtZW50L2ltcGwvU2ltcGxlSnVkZ2VtZW50RW5naW5lLmphdmE=) | `59.09% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ameter/impl/EncryptPredicateParameterRewriter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL2ltcGwvRW5jcnlwdFByZWRpY2F0ZVBhcmFtZXRlclJld3JpdGVyLmphdmE=) | `94.73% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
   | ... and [242 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=footer). Last update [75c9b19...a12f5f9](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4581?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl merged pull request #4581: add ut for for sharding-orchestration-core module

Posted by GitBox <gi...@apache.org>.
dongzl merged pull request #4581: add ut for  for sharding-orchestration-core module
URL: https://github.com/apache/incubator-shardingsphere/pull/4581
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] menghaoranss commented on issue #4581: add ut for for sharding-orchestration-core module

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #4581: add ut for  for sharding-orchestration-core module
URL: https://github.com/apache/incubator-shardingsphere/pull/4581#issuecomment-593948647
 
 
   @zjcnb please fix ci problem: 
   ```
   [ERROR] src/test/java/org/apache/shardingsphere/orchestration/internal/registry/listener/PostShardingConfigCenterRepositoryEventListenerTest.java:[58,83] (misc) FinalParameters: Parameter event should be final.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4581: add ut for for sharding-orchestration-core module

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4581: add ut for  for sharding-orchestration-core module
URL: https://github.com/apache/incubator-shardingsphere/pull/4581#issuecomment-594315594
 
 
   ## Pull Request Test Coverage Report for [Build 9995](https://coveralls.io/builds/29115559)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.006%**) to **57.798%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29115559/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29115559/badge)](https://coveralls.io/builds/29115559) |
   | :-- | --: |
   | Change from base [Build 976](https://coveralls.io/builds/29097004): |  -0.006% |
   | Covered Lines: | 10395 |
   | Relevant Lines: | 17985 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4581: add ut for for sharding-orchestration-core module

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4581: add ut for  for sharding-orchestration-core module
URL: https://github.com/apache/incubator-shardingsphere/pull/4581#issuecomment-594315594
 
 
   ## Pull Request Test Coverage Report for [Build 9997](https://coveralls.io/builds/29117264)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.006%**) to **57.798%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29117264/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29117264/badge)](https://coveralls.io/builds/29117264) |
   | :-- | --: |
   | Change from base [Build 976](https://coveralls.io/builds/29097004): |  -0.006% |
   | Covered Lines: | 10395 |
   | Relevant Lines: | 17985 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services