You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by rb...@locus.apache.org on 2000/12/02 18:42:39 UTC
cvs commit: apr-util/build rules.mk.in
rbb 00/12/02 09:42:39
Modified: build rules.mk.in
Log:
Get the build to at least start. The build still doesn't work, but now
its not a build error.
Revision Changes Path
1.2 +1 -1 apr-util/build/rules.mk.in
Index: rules.mk.in
===================================================================
RCS file: /home/cvs/apr-util/build/rules.mk.in,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- rules.mk.in 2000/12/02 16:13:47 1.1
+++ rules.mk.in 2000/12/02 17:42:38 1.2
@@ -101,7 +101,7 @@
all-recursive depend-recursive clean-recursive distclean-recursive \
extraclean-recursive:
@otarget=`echo $@|sed s/-recursive//`; \
- for i in $(SUBDIRS); do \
+ list='$(SUBDIRS)'; for i in $$list; do \
target="$$otarget"; \
echo "Making $$target in $$i"; \
if test "$$i" = "."; then \
Re: SUBDIRS in top-level makefile (was: Re: cvs commit: apr-util/build
rules.mk.in)
Posted by rb...@covalent.net.
> > We aren't building anything in build or . are we?
>
> "." is there because we build the library. It is ordered after the "src"
> subdirectory.
>
> "build" is there so we can recurse on the various "clean" targets.
>
> Note that "test" is there primarily for the clean targets, too. We probably
> don't want to build things in there (by default).
Makes sense. Thanks for the clarification.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
SUBDIRS in top-level makefile (was: Re: cvs commit: apr-util/build rules.mk.in)
Posted by Greg Stein <gs...@lyra.org>.
On Sat, Dec 02, 2000 at 04:19:13PM -0800, rbb@covalent.net wrote:
>...
> Yep. Quick question for you now, why does the top-level Makefile have:
>
> SUBDIRS = src . test build
>
> It seems to me this should be:
>
> SUBDIRTS = src test
>
> We aren't building anything in build or . are we?
"." is there because we build the library. It is ordered after the "src"
subdirectory.
"build" is there so we can recurse on the various "clean" targets.
Note that "test" is there primarily for the clean targets, too. We probably
don't want to build things in there (by default).
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: apr-util/build rules.mk.in
Posted by rb...@covalent.net.
> > > Mandrake is rpm-based:
> > >
> > > $ rpm -q make bash
> > >
> > > I think the make version might actually be the most important part.
> >
> > I know, but I remove all rpm's just after installing Linux, and re-install
> > most of the system by hand. I dislike using rpms whenever possible.
>
> Masochistic, aren't you? I stopped doing that back in '95 when I switched
Pretty much, yeah. I just like to know what's on my machine. I have an
intense dislike to rpm's. :-)
> Quick question: when you type "make" at the top-level of apr-util (after
> configuring), does it recurse for you?
Yep. Quick question for you now, why does the top-level Makefile have:
SUBDIRS = src . test build
It seems to me this should be:
SUBDIRTS = src test
We aren't building anything in build or . are we?
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: cvs commit: apr-util/build rules.mk.in
Posted by Greg Stein <gs...@lyra.org>.
On Sat, Dec 02, 2000 at 03:42:52PM -0800, rbb@covalent.net wrote:
> > > > What do you have?
> > >
> > > mandrake 7.1
> > > Autoconf version 2.14.1
> > > ltmain.sh (GNU libtool) 1.3.5 (1.385.2.206 2000/05/27 11:12:27)
> > >
> > > I would have to dig to get my bash version.
> >
> > Mandrake is rpm-based:
> >
> > $ rpm -q make bash
> >
> > I think the make version might actually be the most important part.
>
> I know, but I remove all rpm's just after installing Linux, and re-install
> most of the system by hand. I dislike using rpms whenever possible.
Masochistic, aren't you? I stopped doing that back in '95 when I switched
from Slackware to RedHat... :-)
Quick question: when you type "make" at the top-level of apr-util (after
configuring), does it recurse for you?
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: apr-util/build rules.mk.in
Posted by rb...@covalent.net.
> > > What do you have?
> >
> > mandrake 7.1
> > Autoconf version 2.14.1
> > ltmain.sh (GNU libtool) 1.3.5 (1.385.2.206 2000/05/27 11:12:27)
> >
> > I would have to dig to get my bash version.
>
> Mandrake is rpm-based:
>
> $ rpm -q make bash
>
> I think the make version might actually be the most important part.
I know, but I remove all rpm's just after installing Linux, and re-install
most of the system by hand. I dislike using rpms whenever possible.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: cvs commit: apr-util/build rules.mk.in
Posted by Greg Stein <gs...@lyra.org>.
On Sat, Dec 02, 2000 at 03:00:26PM -0800, rbb@covalent.net wrote:
> > Dang. That is just wonky. I've got RedHat 6.1 installed. The relevant
> > packages are:
> >
> > make-3.77-6
> > bash-1.14.7-16
> > autoconf-2.13-5
> > libtool-1.3.4-3
> >
> > What do you have?
>
> mandrake 7.1
> Autoconf version 2.14.1
> ltmain.sh (GNU libtool) 1.3.5 (1.385.2.206 2000/05/27 11:12:27)
>
> I would have to dig to get my bash version.
Mandrake is rpm-based:
$ rpm -q make bash
I think the make version might actually be the most important part.
> > I've got no problem with the change, but I'd like to understand what is
> > going wrong. Why is SUBDIRS always null?
> >
> > Hmm. I wonder if it does the substitution for SUBDIRS when it reads the rule
> > (via the include) rather than when the rule is invoked. In all of the
> > makefiles, SUBDIRS is set after the include. Could that be the problem
> > you're seeing?
>
> Could be. I didn't really investigate, because I was able to solve it by
> just mimicing Apache.
Yah... I saw that code in Apache and decided to simplify... Oops. :-)
Like I said: we should keep it, but "why?" (and I'll comment the code with
the reason...)
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: apr-util/build rules.mk.in
Posted by rb...@covalent.net.
> Dang. That is just wonky. I've got RedHat 6.1 installed. The relevant
> packages are:
>
> make-3.77-6
> bash-1.14.7-16
> autoconf-2.13-5
> libtool-1.3.4-3
>
> What do you have?
mandrake 7.1
Autoconf version 2.14.1
ltmain.sh (GNU libtool) 1.3.5 (1.385.2.206 2000/05/27 11:12:27)
I would have to dig to get my bash version.
> I've got no problem with the change, but I'd like to understand what is
> going wrong. Why is SUBDIRS always null?
>
> Hmm. I wonder if it does the substitution for SUBDIRS when it reads the rule
> (via the include) rather than when the rule is invoked. In all of the
> makefiles, SUBDIRS is set after the include. Could that be the problem
> you're seeing?
Could be. I didn't really investigate, because I was able to solve it by
just mimicing Apache.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: cvs commit: apr-util/build rules.mk.in
Posted by Greg Stein <gs...@lyra.org>.
On Sat, Dec 02, 2000 at 02:00:40PM -0800, rbb@covalent.net wrote:
> On Sat, 2 Dec 2000, Greg Stein wrote:
>
> > What platform are you trying to build on? And what is the problem you're
> > seeing?
> >
> > All of my testing was on Linux, and it worked like a charm (before/after the
> > change below). So... I'm wondering what part isn't working for you?
>
> I'm on Linux, and SUBDIRS was always NULL. This is how Apache does it, so
> I tried just copying from Apache to apr-utils, and it solved my problem.
Dang. That is just wonky. I've got RedHat 6.1 installed. The relevant
packages are:
make-3.77-6
bash-1.14.7-16
autoconf-2.13-5
libtool-1.3.4-3
What do you have?
I've got no problem with the change, but I'd like to understand what is
going wrong. Why is SUBDIRS always null?
Hmm. I wonder if it does the substitution for SUBDIRS when it reads the rule
(via the include) rather than when the rule is invoked. In all of the
makefiles, SUBDIRS is set after the include. Could that be the problem
you're seeing?
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: apr-util/build rules.mk.in
Posted by rb...@covalent.net.
On Sat, 2 Dec 2000, Greg Stein wrote:
> What platform are you trying to build on? And what is the problem you're
> seeing?
>
> All of my testing was on Linux, and it worked like a charm (before/after the
> change below). So... I'm wondering what part isn't working for you?
I'm on Linux, and SUBDIRS was always NULL. This is how Apache does it, so
I tried just copying from Apache to apr-utils, and it solved my problem.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: cvs commit: apr-util/build rules.mk.in
Posted by Greg Stein <gs...@lyra.org>.
What platform are you trying to build on? And what is the problem you're
seeing?
All of my testing was on Linux, and it worked like a charm (before/after the
change below). So... I'm wondering what part isn't working for you?
Cheers,
-g
On Sat, Dec 02, 2000 at 05:42:39PM -0000, rbb@locus.apache.org wrote:
> rbb 00/12/02 09:42:39
>
> Modified: build rules.mk.in
> Log:
> Get the build to at least start. The build still doesn't work, but now
> its not a build error.
>
> Revision Changes Path
> 1.2 +1 -1 apr-util/build/rules.mk.in
>
> Index: rules.mk.in
> ===================================================================
> RCS file: /home/cvs/apr-util/build/rules.mk.in,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- rules.mk.in 2000/12/02 16:13:47 1.1
> +++ rules.mk.in 2000/12/02 17:42:38 1.2
> @@ -101,7 +101,7 @@
> all-recursive depend-recursive clean-recursive distclean-recursive \
> extraclean-recursive:
> @otarget=`echo $@|sed s/-recursive//`; \
> - for i in $(SUBDIRS); do \
> + list='$(SUBDIRS)'; for i in $$list; do \
> target="$$otarget"; \
> echo "Making $$target in $$i"; \
> if test "$$i" = "."; then \
>
>
>
--
Greg Stein, http://www.lyra.org/