[GitHub] [doris] HappenLee commented on a diff in pull request #13323: [function](string_function) add new string function 'extract_url_parameter'

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #13323:
URL: https://github.com/apache/doris/pull/13323#discussion_r995672945


##########
be/src/util/url_parser.cpp:
##########
@@ -344,4 +346,59 @@ UrlParser::UrlPart UrlParser::get_url_part(const StringValue& part) {
     }
 }
 
+std::string UrlParser::extract_url(const StringValue& url, const StringValue& name) {

Review Comment:
   replace all `std::string` by `std::string_view` to speed up the function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org