You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by klickverbot <gi...@git.apache.org> on 2014/10/05 17:21:26 UTC

[GitHub] thrift pull request: D: Fix thrift.internal.traits unittest build.

GitHub user klickverbot opened a pull request:

    https://github.com/apache/thrift/pull/237

    D: Fix thrift.internal.traits unittest build.

    I originally wrote what became std.traits.SetFunctionAttributes
    as thrift.internal.traits.ChangeFuncAttrs. Now that it has been
    in Phobos for a number of releases, remove the local copy.
    
    This is both a cleanup and fixes the -unittest build in 2.066,
    where std.metastrings (which was just a stray import anyway)
    has finally been removed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/klickverbot/thrift d-use-set-function-attributes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #237
    
----
commit 4b28db8999aafb3f3abef10e5baf7bffbddde00b
Author: David Nadlinger <co...@klickverbot.at>
Date:   2014-10-05T15:17:54Z

    D: Fix thrift.internal.traits unittest build.
    
    I originally wrote what became std.traits.SetFunctionAttributes
    as thrift.internal.traits.ChangeFuncAttrs. Now that it has been
    in Phobos for a number of releases, remove the local copy.
    
    This is both a cleanup and fixes the -unittest build in 2.066,
    where std.metastrings (which was just a stray import anyway)
    has finally been removed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: D: Fix thrift.internal.traits unittest build.

Posted by klickverbot <gi...@git.apache.org>.

Github user klickverbot commented on the pull request:

    https://github.com/apache/thrift/pull/237#issuecomment-58164748
  
    @Jens-G: I didn't realize that there are supposed to be tickets for trivial code changes such as this too (changelog generation?). Filed two bugs and updated the commit messages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: D: Fix thrift.internal.traits unittest build.

Posted by Jens-G <gi...@git.apache.org>.

Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/237#issuecomment-57943272
  
    Hi, 
    [are there already any JIRA tickets](http://thrift.apache,org/docs/HowToContribute) for these pull requests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: D: Fix thrift.internal.traits unittest build.

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/237


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: D: Fix thrift.internal.traits unittest build.

Posted by Jens-G <gi...@git.apache.org>.

Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/237#issuecomment-58242100
  
    Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---