[GitHub] [pulsar-client-node] ken-browning opened a new issue, #212: Now that acknowledge returns a Promise, should negativeAcknowledge return a Promise too?

[GitBox <gi...@apache.org>]

ken-browning opened a new issue, #212:
URL: https://github.com/apache/pulsar-client-node/issues/212

   The `acknowledge` method of the `Consumer` type was recently updated to return a `Promise`. Should the `negativeAcknowledge` method also return a `Promise`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-node] Matt-Esch commented on issue #212: Now that acknowledge returns a Promise, should negativeAcknowledge return a Promise too?

[GitBox <gi...@apache.org>]

Matt-Esch commented on issue #212:
URL: https://github.com/apache/pulsar-client-node/issues/212#issuecomment-1119855467

   I would have made it return a promise if the underlying c api had an async callback, but it doesn't.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org