You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/05/05 11:44:01 UTC

[GitHub] [couchdb] iilyak commented on a change in pull request #3544: Handle the case when md5 field is undefined

iilyak commented on a change in pull request #3544:
URL: https://github.com/apache/couchdb/pull/3544#discussion_r626492487



##########
File path: src/couch/src/couch_att.erl
##########
@@ -346,9 +346,14 @@ to_json(Att, OutputData, DataToFollow, ShowEncoding) ->
         {<<"content_type">>, Type},
         {<<"revpos">>, RevPos}
     ],
-    DigestProp = case base64:encode(Md5) of
-        <<>> -> [];
-        Digest -> [{<<"digest">>, <<"md5-", Digest/binary>>}]
+    DigestProp = case Md5 of
+        <<>> ->

Review comment:
       Nice catch!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org