You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/18 09:11:12 UTC

[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22258: Update Oracle SQL XMLCOLATTVAL function parse

RaigorJiang commented on code in PR #22258:
URL: https://github.com/apache/shardingsphere/pull/22258#discussion_r1026185477


##########
sql-parser/dialect/oracle/src/main/antlr4/imports/oracle/BaseRule.g4:
##########
@@ -1616,8 +1616,13 @@ datetimeExpr
 
 xmlFunction
     : xmlAggFunction
+    | xmlColattvalFunction
     ;
 
 xmlAggFunction
     : XMLAGG LP_ expr orderByClause? RP_
     ;
+
+xmlColattvalFunction
+    :XMLCOLATTVAL LP_ expr (AS (alias | EVALNAME expr))? (COMMA_ expr (AS (alias | EVALNAME expr))?)* RP_

Review Comment:
   Missed a white space here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org