You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "CurtHagenlocher (via GitHub)" <gi...@apache.org> on 2023/11/22 14:37:01 UTC
[PR] build(csharp): Build C# code in continuous integration [arrow-adbc]
CurtHagenlocher opened a new pull request, #1320:
URL: https://github.com/apache/arrow-adbc/pull/1320
(I have no idea what I'm doing; trying this to see if it works :).)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: Build C# code in continuous integration [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on code in PR #1320:
URL: https://github.com/apache/arrow-adbc/pull/1320#discussion_r1406479777
##########
.github/workflows/csharp.yml:
##########
@@ -0,0 +1,116 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: C#
+
+on:
+ push:
+ paths:
+ - '.github/workflows/csharp.yml'
+ - 'ci/scripts/csharp_*'
+ - 'csharp/**'
+ pull_request:
+ paths:
+ - '.github/workflows/csharp.yml'
+ - 'ci/scripts/csharp_*'
+ - 'csharp/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+jobs:
+
+ ubuntu:
Review Comment:
I'm totally cargo-culting this. Let's see if I can make that work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(csharp): Build C# code in continuous integration [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #1320:
URL: https://github.com/apache/arrow-adbc/pull/1320#issuecomment-1822931459
Down payment against #750.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(csharp): Build C# code in continuous integration [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #1320:
URL: https://github.com/apache/arrow-adbc/pull/1320#issuecomment-1823293931
Ah, okay. Thanks. Yes, we clearly want to update packaging.yml too, then, but my immediate concern is that a build break got checked in because we're not even running a build in CI today. Running tests and building release artifacts will be "next steps".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(csharp): Build C# code in continuous integration [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1320:
URL: https://github.com/apache/arrow-adbc/pull/1320#issuecomment-1823287544
packaging.yml is the pipeline triggered for releases, if you need to build binary artifacts. If not there is no issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(csharp): Build C# code in continuous integration [arrow-adbc]
Posted by "davidhcoe (via GitHub)" <gi...@apache.org>.
davidhcoe commented on PR #1320:
URL: https://github.com/apache/arrow-adbc/pull/1320#issuecomment-1823197155
Thanks, Curt. I started down a similar path in https://github.com/davidhcoe/arrow-adbc/blob/0322c175d7e9761dcf1471d43a0ff95354c218f3/.github/workflows/packaging.yml#L831 as part of addressing https://github.com/apache/arrow-adbc/issues/1121. At that time, @lidavidm said the scripts needed to go in [/.github/workflows/packaging.yml](https://github.com/apache/arrow-adbc/blob/main/.github/workflows/packaging.yml). Not sure how the current setup will build the csharp.yml file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(csharp): Build C# code in continuous integration [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #1320:
URL: https://github.com/apache/arrow-adbc/pull/1320#issuecomment-1823279474
However it works, you can see in the "All checks" list that there are now three C# builds and all have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(csharp): Build C# code in continuous integration [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #1320:
URL: https://github.com/apache/arrow-adbc/pull/1320#discussion_r1406409206
##########
.github/workflows/csharp.yml:
##########
@@ -0,0 +1,116 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: C#
+
+on:
+ push:
+ paths:
+ - '.github/workflows/csharp.yml'
+ - 'ci/scripts/csharp_*'
+ - 'csharp/**'
+ pull_request:
+ paths:
+ - '.github/workflows/csharp.yml'
+ - 'ci/scripts/csharp_*'
+ - 'csharp/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 18.04 C# ${{ matrix.dotnet }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 15
+ strategy:
+ fail-fast: false
+ matrix:
+ dotnet: ['7.0.x']
+ steps:
+ - name: Install C#
+ uses: actions/setup-dotnet@v3
+ with:
+ dotnet-version: ${{ matrix.dotnet }}
+ - name: Checkout ADBC
+ uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Install Source Link
+ shell: bash
+ run: dotnet tool install --global sourcelink
+ - name: Build
+ shell: bash
+ run: ci/scripts/csharp_build.sh $(pwd)
Review Comment:
I guess we're not using the docker-compose definition? Do we need it at all?
##########
.github/workflows/csharp.yml:
##########
@@ -0,0 +1,116 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: C#
+
+on:
+ push:
+ paths:
+ - '.github/workflows/csharp.yml'
+ - 'ci/scripts/csharp_*'
+ - 'csharp/**'
+ pull_request:
+ paths:
+ - '.github/workflows/csharp.yml'
+ - 'ci/scripts/csharp_*'
+ - 'csharp/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 18.04 C# ${{ matrix.dotnet }}
Review Comment:
nit: ubuntu-latest is 22.04 now
##########
.github/workflows/csharp.yml:
##########
@@ -0,0 +1,116 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: C#
+
+on:
+ push:
+ paths:
+ - '.github/workflows/csharp.yml'
+ - 'ci/scripts/csharp_*'
+ - 'csharp/**'
+ pull_request:
+ paths:
+ - '.github/workflows/csharp.yml'
+ - 'ci/scripts/csharp_*'
+ - 'csharp/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+jobs:
+
+ ubuntu:
Review Comment:
If the platforms are identical, could we consolidate them into a matrix argument?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: Build C# code in continuous integration [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #1320:
URL: https://github.com/apache/arrow-adbc/pull/1320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org