You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/27 13:18:06 UTC
[GitHub] [flink] matriv opened a new pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
matriv opened a new pull request #18540:
URL: https://github.com/apache/flink/pull/18540
`table.exec.topn.cache-size` config option was previously defined inside
`StreamExecRank` and still marked as experimental. Move it to
`ExecutionConfigOptions` and generate the corresponding docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #18540:
URL: https://github.com/apache/flink/pull/18540#discussion_r794448193
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -414,6 +415,16 @@
"Determines whether CAST will operate following the legacy behaviour "
+ "or the new one that introduces various fixes and improvements.");
+ @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ public static final ConfigOption<Long> TABLE_EXEC_TOPN_CACHE_SIZE =
+ ConfigOptions.key("table.exec.topn.cache-size")
Review comment:
Thx, please check again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
}, {
"hash" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676",
"triggerID" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"triggerType" : "PUSH"
}, {
"hash" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75f4a34a011be059d5af2412764bdd5d7b49253e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676)
* fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
}, {
"hash" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676",
"triggerID" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"triggerType" : "PUSH"
}, {
"hash" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30716",
"triggerID" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"triggerType" : "PUSH"
}, {
"hash" : "c55c49cd2b7b66849f6efaa5f640c304da0b1238",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30767",
"triggerID" : "c55c49cd2b7b66849f6efaa5f640c304da0b1238",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c55c49cd2b7b66849f6efaa5f640c304da0b1238 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30767)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #18540:
URL: https://github.com/apache/flink/pull/18540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d33df68101740a3c1295dfc7c46ead1740e4cd0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
}, {
"hash" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676",
"triggerID" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75f4a34a011be059d5af2412764bdd5d7b49253e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
}, {
"hash" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676",
"triggerID" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"triggerType" : "PUSH"
}, {
"hash" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30716",
"triggerID" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75f4a34a011be059d5af2412764bdd5d7b49253e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676)
* fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30716)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d33df68101740a3c1295dfc7c46ead1740e4cd0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313)
* d064a574df375388daad0042b1ee68729db5af4e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d33df68101740a3c1295dfc7c46ead1740e4cd0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
}, {
"hash" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676",
"triggerID" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"triggerType" : "PUSH"
}, {
"hash" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30716",
"triggerID" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"triggerType" : "PUSH"
}, {
"hash" : "c55c49cd2b7b66849f6efaa5f640c304da0b1238",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30767",
"triggerID" : "c55c49cd2b7b66849f6efaa5f640c304da0b1238",
"triggerType" : "PUSH"
}, {
"hash" : "811e0f4dafd90eb1193cdc41a95d515951f9b125",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "811e0f4dafd90eb1193cdc41a95d515951f9b125",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c55c49cd2b7b66849f6efaa5f640c304da0b1238 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30767)
* 811e0f4dafd90eb1193cdc41a95d515951f9b125 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
}, {
"hash" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676",
"triggerID" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"triggerType" : "PUSH"
}, {
"hash" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30716",
"triggerID" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"triggerType" : "PUSH"
}, {
"hash" : "c55c49cd2b7b66849f6efaa5f640c304da0b1238",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c55c49cd2b7b66849f6efaa5f640c304da0b1238",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30716)
* c55c49cd2b7b66849f6efaa5f640c304da0b1238 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d064a574df375388daad0042b1ee68729db5af4e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
}, {
"hash" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676",
"triggerID" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"triggerType" : "PUSH"
}, {
"hash" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30716",
"triggerID" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30716)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
}, {
"hash" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d064a574df375388daad0042b1ee68729db5af4e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402)
* 75f4a34a011be059d5af2412764bdd5d7b49253e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1028157613
I know naming is a difficult issue but I would still prefer: `table.exec.rank.topn-cache-size` instead of `table.exec.rank-topn.cache-size`. Top-N belongs to the rank ExecNode and components of a key should be hierarchical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
}, {
"hash" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676",
"triggerID" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"triggerType" : "PUSH"
}, {
"hash" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30716",
"triggerID" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"triggerType" : "PUSH"
}, {
"hash" : "c55c49cd2b7b66849f6efaa5f640c304da0b1238",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30767",
"triggerID" : "c55c49cd2b7b66849f6efaa5f640c304da0b1238",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30716)
* c55c49cd2b7b66849f6efaa5f640c304da0b1238 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30767)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1028826011
> I know naming is a difficult issue but I would still prefer: `table.exec.rank.topn-cache-size` instead of `table.exec.rank-topn.cache-size`. Top-N belongs to the rank ExecNode and components of a key should be hierarchical.
No worries, I think I just didn't remember it, It's my fault, please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
}, {
"hash" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676",
"triggerID" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d064a574df375388daad0042b1ee68729db5af4e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402)
* 75f4a34a011be059d5af2412764bdd5d7b49253e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d33df68101740a3c1295dfc7c46ead1740e4cd0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313)
* d064a574df375388daad0042b1ee68729db5af4e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023207155
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1d33df68101740a3c1295dfc7c46ead1740e4cd0 (Thu Jan 27 13:24:44 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d33df68101740a3c1295dfc7c46ead1740e4cd0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18540:
URL: https://github.com/apache/flink/pull/18540#discussion_r794388640
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -414,6 +415,16 @@
"Determines whether CAST will operate following the legacy behaviour "
+ "or the new one that introduces various fixes and improvements.");
+ @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ public static final ConfigOption<Long> TABLE_EXEC_TOPN_CACHE_SIZE =
+ ConfigOptions.key("table.exec.topn.cache-size")
Review comment:
`topn` is an outdated name. Use `rank` everywhere like `table.exec.rank.cache-size` to be consistent. The old key can be declared as a deprecated key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18540: [hotfix][table-planner][table-api-java][docs] Move topn cache config option
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18540:
URL: https://github.com/apache/flink/pull/18540#issuecomment-1023208881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30313",
"triggerID" : "1d33df68101740a3c1295dfc7c46ead1740e4cd0",
"triggerType" : "PUSH"
}, {
"hash" : "d064a574df375388daad0042b1ee68729db5af4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30402",
"triggerID" : "d064a574df375388daad0042b1ee68729db5af4e",
"triggerType" : "PUSH"
}, {
"hash" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30676",
"triggerID" : "75f4a34a011be059d5af2412764bdd5d7b49253e",
"triggerType" : "PUSH"
}, {
"hash" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30716",
"triggerID" : "fd257c00cd656fbe45bd9fbbb2dcadcf98c7c587",
"triggerType" : "PUSH"
}, {
"hash" : "c55c49cd2b7b66849f6efaa5f640c304da0b1238",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30767",
"triggerID" : "c55c49cd2b7b66849f6efaa5f640c304da0b1238",
"triggerType" : "PUSH"
}, {
"hash" : "811e0f4dafd90eb1193cdc41a95d515951f9b125",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30827",
"triggerID" : "811e0f4dafd90eb1193cdc41a95d515951f9b125",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c55c49cd2b7b66849f6efaa5f640c304da0b1238 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30767)
* 811e0f4dafd90eb1193cdc41a95d515951f9b125 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30827)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org