You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/12/03 21:24:22 UTC

[GitHub] [geode] kirklund opened a new pull request #7166: GEODE-9758: Move ClassUtils to geode-common

kirklund opened a new pull request #7166:
URL: https://github.com/apache/geode/pull/7166


   Serialization filtering pull requests can be very large so it may be
   better to submit this change separately to help with reviews.
   
   Move ClassUtils to geode-common.
   
   Remove "JUnit" from the name of a couple tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] kirklund merged pull request #7166: GEODE-9758: Move ClassUtils to geode-common

Posted by GitBox <gi...@apache.org>.
kirklund merged pull request #7166:
URL: https://github.com/apache/geode/pull/7166


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] kirklund merged pull request #7166: GEODE-9758: Move ClassUtils to geode-common

Posted by GitBox <gi...@apache.org>.
kirklund merged pull request #7166:
URL: https://github.com/apache/geode/pull/7166


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill commented on pull request #7166: GEODE-9758: Move ClassUtils to geode-common

Posted by GitBox <gi...@apache.org>.
Bill commented on pull request #7166:
URL: https://github.com/apache/geode/pull/7166#issuecomment-989384550


   I approved the first commit in the other PR. But I don't understand why, in this PR, `ClassUtils` needs to move to `geode-common`.
   
   I'm all for reducing the size of `geode-core` but I wonder if there was something particular, outside `geode-core` that maybe needed access to that class?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] kirklund commented on pull request #7166: GEODE-9758: Move ClassUtils to geode-common

Posted by GitBox <gi...@apache.org>.
kirklund commented on pull request #7166:
URL: https://github.com/apache/geode/pull/7166#issuecomment-988280161


   GeodeRedisServerStartupDUnitTest failed with a BindException


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org