[GitHub] [flink] azagrebin commented on issue #8759: [FLINK-12868][yarn] Fix yarn cluster can not be deployed if plugins dir does not exist

[GitBox <gi...@apache.org>]

azagrebin commented on issue #8759: [FLINK-12868][yarn] Fix yarn cluster can not be deployed if plugins dir does not exist
URL: https://github.com/apache/flink/pull/8759#issuecomment-503539104
 
 
   We should also at least add a similar warning if the configured directory does not exist where it is actually used in `PluginConfig.getPluginsDirPath`.
   
   But thinking more about it, as @TisonKun pointed out, ideally we should fail fast like it happens for `lib` atm. The `lib` checks do not fail because our dist build result always contains `lib` hard-set in `config.sh` (see `flink-dist/src/main/assemblies/bin.xml`). We should do the same for plugins and the docs should mention this directory as a standard place to put custom plugins in client dist. Then all existing and modified in this PR code paths should fail fast if the directory is set but does not exist including `PluginConfig.getPluginsDirPath`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services