[GitHub] [iceberg] kbendick commented on pull request #5358: Spec: Always send the properties

[GitBox <gi...@apache.org>]

kbendick commented on PR #5358:
URL: https://github.com/apache/iceberg/pull/5358#issuecomment-1195727449

   Small correction: Right now, as the field is not marked as required, implementors can skip sending the field entirely (as opposed to only having the option to send null).
   
   We tend to do that within some of the `*Parser.toJson` functions in Java for null (e.g. not set the field).
   
   There's nothing stopping implementors from sending the empty dict now, but the Java code at least defensively returns an empty ImmutableMap in case it parses `null`: https://github.com/apache/iceberg/blob/39878c629a6738b0fc99987ccb80da4511525bdc/core/src/main/java/org/apache/iceberg/rest/requests/CreateNamespaceRequest.java#L58-L60
   
   Is there a benefit on the Python side to this requirement?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org