You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/03/27 22:47:37 UTC

Review Request 32575: [WinTP2] ambari-web build is incomplete

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32575/
-----------------------------------------------------------

Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-10243
    https://issues.apache.org/jira/browse/AMBARI-10243


Repository: ambari


Description
-------

Replaced maven-antrun-plugin with exec-maven-plugin. Upgraded to v1.2.1 was necessary because v1.2 doesn't process the <successCodes> tag.
Created Windows scripts with identical functionality for set-ambari-version.sh, set-default-stack-version.sh and toggle-experimental.sh.


Diffs
-----

  ambari-agent/pom.xml 110a8d57cdb3b50efd47b095a3c813efb2d1b1d6 
  ambari-client/python-client/pom.xml 3c957eec606c441e91aec36d7d5f7af64620c999 
  ambari-metrics/ambari-metrics-assembly/pom.xml e7054d6f0a44c519205a2f3f5ad69098de7ba289 
  ambari-server/pom.xml 18593bd138458d7f1a92f2d2c99584c03428df67 
  ambari-shell/ambari-python-shell/pom.xml d78c6ea978f6475cbdcad579522fd1cd39039246 
  ambari-web/pom.xml 0849111c4cbd47edf999a51dfae1283532aaa8f9 
  ambari-web/set-ambari-version.cmd PRE-CREATION 
  ambari-web/set-ambari-version.ps1 PRE-CREATION 
  ambari-web/set-default-stack-version.cmd PRE-CREATION 
  ambari-web/set-default-stack-version.ps1 PRE-CREATION 
  ambari-web/toggle-experimental.cmd PRE-CREATION 
  ambari-web/toggle-experimental.ps1 PRE-CREATION 
  contrib/views/slider/pom.xml cf5c0c5cbc6a22b5ffcd8c2d7db7e5cb7c32304c 

Diff: https://reviews.apache.org/r/32575/diff/


Testing
-------

mvn clean install -X -> no more error messages, the directories get deleted and created ok


Thanks,

Florian Barca


Re: Review Request 32575: [WinTP2] ambari-web build is incomplete

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32575/#review78256
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On March 27, 2015, 9:47 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32575/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 9:47 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10243
>     https://issues.apache.org/jira/browse/AMBARI-10243
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Replaced maven-antrun-plugin with exec-maven-plugin. Upgraded to v1.2.1 was necessary because v1.2 doesn't process the <successCodes> tag.
> Created Windows scripts with identical functionality for set-ambari-version.sh, set-default-stack-version.sh and toggle-experimental.sh.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml 110a8d57cdb3b50efd47b095a3c813efb2d1b1d6 
>   ambari-client/python-client/pom.xml 3c957eec606c441e91aec36d7d5f7af64620c999 
>   ambari-metrics/ambari-metrics-assembly/pom.xml e7054d6f0a44c519205a2f3f5ad69098de7ba289 
>   ambari-server/pom.xml 18593bd138458d7f1a92f2d2c99584c03428df67 
>   ambari-shell/ambari-python-shell/pom.xml d78c6ea978f6475cbdcad579522fd1cd39039246 
>   ambari-web/pom.xml 0849111c4cbd47edf999a51dfae1283532aaa8f9 
>   ambari-web/set-ambari-version.cmd PRE-CREATION 
>   ambari-web/set-ambari-version.ps1 PRE-CREATION 
>   ambari-web/set-default-stack-version.cmd PRE-CREATION 
>   ambari-web/set-default-stack-version.ps1 PRE-CREATION 
>   ambari-web/toggle-experimental.cmd PRE-CREATION 
>   ambari-web/toggle-experimental.ps1 PRE-CREATION 
>   contrib/views/slider/pom.xml cf5c0c5cbc6a22b5ffcd8c2d7db7e5cb7c32304c 
> 
> Diff: https://reviews.apache.org/r/32575/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install -X -> no more error messages, the directories get deleted and created ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 32575: [WinTP2] ambari-web build is incomplete

Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32575/#review78349
-----------------------------------------------------------

Ship it!


Ship It!

- Eugene Chekanskiy


On March 31, 2015, 4:17 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32575/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 4:17 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10243
>     https://issues.apache.org/jira/browse/AMBARI-10243
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Replaced maven-antrun-plugin with exec-maven-plugin. Upgraded to v1.2.1 was necessary because v1.2 doesn't process the <successCodes> tag.
> Created Windows scripts with identical functionality for set-ambari-version.sh, set-default-stack-version.sh and toggle-experimental.sh.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml 110a8d57cdb3b50efd47b095a3c813efb2d1b1d6 
>   ambari-client/python-client/pom.xml 3c957eec606c441e91aec36d7d5f7af64620c999 
>   ambari-metrics/ambari-metrics-assembly/pom.xml cf7a92deac40ab9635d6be6a6979f0f70289124b 
>   ambari-server/pom.xml 18593bd138458d7f1a92f2d2c99584c03428df67 
>   ambari-shell/ambari-python-shell/pom.xml d78c6ea978f6475cbdcad579522fd1cd39039246 
>   ambari-web/pom.xml 0849111c4cbd47edf999a51dfae1283532aaa8f9 
>   ambari-web/set-ambari-version.cmd PRE-CREATION 
>   ambari-web/set-ambari-version.ps1 PRE-CREATION 
>   ambari-web/set-default-stack-version.cmd PRE-CREATION 
>   ambari-web/set-default-stack-version.ps1 PRE-CREATION 
>   ambari-web/toggle-experimental.cmd PRE-CREATION 
>   ambari-web/toggle-experimental.ps1 PRE-CREATION 
>   contrib/views/slider/pom.xml cf5c0c5cbc6a22b5ffcd8c2d7db7e5cb7c32304c 
> 
> Diff: https://reviews.apache.org/r/32575/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install -X -> no more error messages, the directories get deleted and created ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 32575: [WinTP2] ambari-web build is incomplete

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32575/#review78343
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On March 31, 2015, 4:17 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32575/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 4:17 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10243
>     https://issues.apache.org/jira/browse/AMBARI-10243
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Replaced maven-antrun-plugin with exec-maven-plugin. Upgraded to v1.2.1 was necessary because v1.2 doesn't process the <successCodes> tag.
> Created Windows scripts with identical functionality for set-ambari-version.sh, set-default-stack-version.sh and toggle-experimental.sh.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml 110a8d57cdb3b50efd47b095a3c813efb2d1b1d6 
>   ambari-client/python-client/pom.xml 3c957eec606c441e91aec36d7d5f7af64620c999 
>   ambari-metrics/ambari-metrics-assembly/pom.xml cf7a92deac40ab9635d6be6a6979f0f70289124b 
>   ambari-server/pom.xml 18593bd138458d7f1a92f2d2c99584c03428df67 
>   ambari-shell/ambari-python-shell/pom.xml d78c6ea978f6475cbdcad579522fd1cd39039246 
>   ambari-web/pom.xml 0849111c4cbd47edf999a51dfae1283532aaa8f9 
>   ambari-web/set-ambari-version.cmd PRE-CREATION 
>   ambari-web/set-ambari-version.ps1 PRE-CREATION 
>   ambari-web/set-default-stack-version.cmd PRE-CREATION 
>   ambari-web/set-default-stack-version.ps1 PRE-CREATION 
>   ambari-web/toggle-experimental.cmd PRE-CREATION 
>   ambari-web/toggle-experimental.ps1 PRE-CREATION 
>   contrib/views/slider/pom.xml cf5c0c5cbc6a22b5ffcd8c2d7db7e5cb7c32304c 
> 
> Diff: https://reviews.apache.org/r/32575/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install -X -> no more error messages, the directories get deleted and created ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 32575: [WinTP2] ambari-web build is incomplete

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32575/
-----------------------------------------------------------

(Updated March 31, 2015, 4:17 a.m.)


Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, Srimanth Gunturi, and Yusaku Sako.


Changes
-------

Fixed slider views build.


Bugs: AMBARI-10243
    https://issues.apache.org/jira/browse/AMBARI-10243


Repository: ambari


Description
-------

Replaced maven-antrun-plugin with exec-maven-plugin. Upgraded to v1.2.1 was necessary because v1.2 doesn't process the <successCodes> tag.
Created Windows scripts with identical functionality for set-ambari-version.sh, set-default-stack-version.sh and toggle-experimental.sh.


Diffs (updated)
-----

  ambari-agent/pom.xml 110a8d57cdb3b50efd47b095a3c813efb2d1b1d6 
  ambari-client/python-client/pom.xml 3c957eec606c441e91aec36d7d5f7af64620c999 
  ambari-metrics/ambari-metrics-assembly/pom.xml cf7a92deac40ab9635d6be6a6979f0f70289124b 
  ambari-server/pom.xml 18593bd138458d7f1a92f2d2c99584c03428df67 
  ambari-shell/ambari-python-shell/pom.xml d78c6ea978f6475cbdcad579522fd1cd39039246 
  ambari-web/pom.xml 0849111c4cbd47edf999a51dfae1283532aaa8f9 
  ambari-web/set-ambari-version.cmd PRE-CREATION 
  ambari-web/set-ambari-version.ps1 PRE-CREATION 
  ambari-web/set-default-stack-version.cmd PRE-CREATION 
  ambari-web/set-default-stack-version.ps1 PRE-CREATION 
  ambari-web/toggle-experimental.cmd PRE-CREATION 
  ambari-web/toggle-experimental.ps1 PRE-CREATION 
  contrib/views/slider/pom.xml cf5c0c5cbc6a22b5ffcd8c2d7db7e5cb7c32304c 

Diff: https://reviews.apache.org/r/32575/diff/


Testing
-------

mvn clean install -X -> no more error messages, the directories get deleted and created ok


Thanks,

Florian Barca