You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/11/01 01:28:37 UTC
Review Request 39834: Made `path_tests.cpp` standalone.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Made `path_tests.cpp` standalone.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp ad9ce324eaf940f68d04c6db7ba37d05efb1216a
Diff: https://reviews.apache.org/r/39834/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39834: Made `path_tests.cpp` standalone.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/#review104646
-----------------------------------------------------------
Bad patch!
Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 39560, 39583, 39584, 39620, 39621, 39622, 39623, 39019, 39802, 39803]
Failed command: ./support/apply-review.sh -n -r 39803
Error:
2015-11-01 00:50:37 URL:https://reviews.apache.org/r/39803/diff/raw/ [18127/18127] -> "39803.patch" [1]
Successfully applied: Windows: Implemented stout/os/stat.hpp`.
Windows: Implemented stout/os/stat.hpp`.
Review: https://reviews.apache.org/r/39803
Checking 4 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp:109: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
Total errors found: 1
Failed to commit patch
- Mesos ReviewBot
On Nov. 1, 2015, 12:28 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39834/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2015, 12:28 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made `path_tests.cpp` standalone.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp ad9ce324eaf940f68d04c6db7ba37d05efb1216a
>
> Diff: https://reviews.apache.org/r/39834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39834: Made `path_tests.cpp` standalone.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/#review105150
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp (lines 21 - 22)
<https://reviews.apache.org/r/39834/#comment163563>
You might also want `<stout/os/exists.hpp>`, `<stout/os/open.hpp`>, and `<stout/os/getcwd.hpp>`.
- Joseph Wu
On Nov. 2, 2015, 10:36 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39834/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 10:36 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made `path_tests.cpp` standalone.
>
> NB, more of these tests will move when `Hopcroft` is done with his `os::symlink` changeset.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp ad9ce324eaf940f68d04c6db7ba37d05efb1216a
>
> Diff: https://reviews.apache.org/r/39834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39834: Made `path_tests.cpp` standalone.
Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/#review112622
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Naparu
On Nov. 16, 2015, 9:14 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39834/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 9:14 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made `path_tests.cpp` standalone.
>
> NB, more of these tests will move when `Hopcroft` is done with his `os::symlink` changeset.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp ad9ce324eaf940f68d04c6db7ba37d05efb1216a
>
> Diff: https://reviews.apache.org/r/39834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39834: Made `path_tests.cpp` standalone.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/#review114883
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 4, 2016, 7:10 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39834/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 7:10 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made `path_tests.cpp` standalone.
>
> NB, more of these tests will move when `Hopcroft` is done with his `os::symlink` changeset.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 821dbb185f09e2f279d95fd354ce2168cddf1bac
>
> Diff: https://reviews.apache.org/r/39834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39834: Made `path_tests.cpp` standalone.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/#review112670
-----------------------------------------------------------
Bad patch!
Reviews applied: [39621, 39620, 39622, 39623, 39019, 39803]
Failed command: ./support/apply-review.sh -n -r 39803
Error:
2016-01-04 22:34:07 URL:https://reviews.apache.org/r/39803/diff/raw/ [20944/20944] -> "39803.patch" [1]
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp:118: Lines should be <= 80 characters long [whitespace/line_length] [2]
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp:68: Lines should be <= 80 characters long [whitespace/line_length] [2]
Total errors found: 1
Checking 4 files
- Mesos ReviewBot
On Jan. 4, 2016, 7:10 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39834/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 7:10 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made `path_tests.cpp` standalone.
>
> NB, more of these tests will move when `Hopcroft` is done with his `os::symlink` changeset.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 821dbb185f09e2f279d95fd354ce2168cddf1bac
>
> Diff: https://reviews.apache.org/r/39834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39834: Made `path_tests.cpp` standalone.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 7:10 p.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Made `path_tests.cpp` standalone.
NB, more of these tests will move when `Hopcroft` is done with his `os::symlink` changeset.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 821dbb185f09e2f279d95fd354ce2168cddf1bac
Diff: https://reviews.apache.org/r/39834/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39834: Made `path_tests.cpp` standalone.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 9:14 a.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Made `path_tests.cpp` standalone.
NB, more of these tests will move when `Hopcroft` is done with his `os::symlink` changeset.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp ad9ce324eaf940f68d04c6db7ba37d05efb1216a
Diff: https://reviews.apache.org/r/39834/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39834: Made `path_tests.cpp` standalone.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 6:36 p.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description (updated)
-------
Made `path_tests.cpp` standalone.
NB, more of these tests will move when `Hopcroft` is done with his `os::symlink` changeset.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp ad9ce324eaf940f68d04c6db7ba37d05efb1216a
Diff: https://reviews.apache.org/r/39834/diff/
Testing
-------
Thanks,
Alex Clemmer