[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3590: ARTEMIS-3309 Add a parameter to limit messages to move or transfer

[GitBox <gi...@apache.org>]

brusdev commented on a change in pull request #3590:
URL: https://github.com/apache/activemq-artemis/pull/3590#discussion_r637923463



##########
File path: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/Transfer.java
##########
@@ -105,10 +105,207 @@
    @Option(name = "--target-topic", description = "Destination to be used. It can be prefixed with queue:// or topic:// and can be an FQQN in the form of <address>::<queue>. (Default: queue://TEST)")
    String targetTopic;
 
-   boolean isCopy() {
+   @Option(name = "--max-count", description = "The maximum number of messages to transfer.")

Review comment:
       The `max-count` parameter has a different name from `message-count` because it has  a different semantic. The first one defines the maximum number of messages to transfer while the second one would define the exact number of messages to transfer waiting if the available messages are less than the `message-count` value (as the consumer does).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org